WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#28670 closed defect (bug) (fixed)

Twenty Fourteen: custom header inline css needs RTL adjustment

Reported by: yoavf's profile yoavf Owned by:
Milestone: 4.0 Priority: low
Severity: minor Version: 3.8
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

See attached image - text on the custom header preview has wrong margin in RTL.

Attachments (3)

Screen Shot 2014-06-29 at 11.06.02.png​ (13.8 KB) - added by yoavf 10 years ago.
28670.diff​ (537 bytes) - added by yoavf 10 years ago.
28670.2.diff​ (470 bytes) - added by yoavf 10 years ago.

Download all attachments as: .zip

Change History (9)

@yoavf
10 years ago

@yoavf
10 years ago

#1 @yoavf
10 years ago

  • Milestone changed from Awaiting Review to 4.0

#2 follow-up: @obenland
10 years ago

  • Component changed from Themes to Bundled Theme

Can we do it with an additional selector, along the lines of this? (untested)

.rtl.appearance_page_custom-header #headimg {
     margin: 0 30px 0 0;
}

#3 @lancewillett
10 years ago

  • Keywords reporter-feedback added

@yoavf
10 years ago

#4 in reply to: ↑ 2 @yoavf
10 years ago

  • Keywords reporter-feedback removed

Replying to obenland:

Can we do it with an additional selector, along the lines of this? (untested)

Yes, see 28670.2.diff​ - both works, whatever you think is best.

#5 @obenland
10 years ago

  • Keywords commit added

Tested, fixes the bug.

#6 @lancewillett
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r29167 (not sure why it isn't auto-closed).

Note: See TracTickets for help on using tickets.