WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#28674 closed enhancement (fixed)

Demote WP Logo from tabindex on setup screen

Reported by: stompweb Owned by: johnbillion
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Upgrade/Install Keywords: has-patch commit
Focuses: ui, accessibility Cc:

Description

As there is no tabindex set on the setup config screen, the WP logo is the first tab index as it appears at the top of the page.

To improve the experience for keyboard users I've demoted the logo's tab index to "-1" so users do not have to tab past it to continuing setting up their install.

It might be that we have to give all the form fields a tabindex and give the logo a larger one but I wanted to see if this was a valid ticket first.

Attachments (2)

28674.diff (584 bytes) - added by stompweb 6 years ago.
28674-1.diff (2.8 KB) - added by stompweb 6 years ago.
Added fix for all files

Download all attachments as: .zip

Change History (11)

@stompweb
6 years ago

#2 follow-up: @stompweb
6 years ago

Need to establish if demoting the WP logo using "-1" is the best way to go, or making sure that everything on all of those scripts has a tab index.

I'm not sure that being able to easy tab to the logo which links to WordPress.org is important at all in any of those process so I'm happy to demote it, but would be good to know from a UX/accessibility point of view.

#3 in reply to: ↑ 2 @SergeyBiryukov
6 years ago

Replying to stompweb:

Need to establish if demoting the WP logo using "-1" is the best way to go, or making sure that everything on all of those scripts has a tab index.

tabindex="-1" for the WP logo would be a preferred way, see #21340.

Last edited 6 years ago by SergeyBiryukov (previous) (diff)

@stompweb
6 years ago

Added fix for all files

#4 @MikeLittle
6 years ago

This patch works for me in all five places.
Note: The wp-login.php page has inline JavaScript to focus the first form field except when the loggedout=true parameter is present. In both versions of wp-login.php the patch is still valid and works.

Well done stompweb!

Last edited 6 years ago by MikeLittle (previous) (diff)

#5 @willmot
6 years ago

Tested this at the WordCamp Manchester Contributor day, resolves the issue in all cases. Nice work @stompweb

#6 @johnbillion
6 years ago

  • Component changed from General to Upgrade/Install
  • Milestone changed from Awaiting Review to 4.0

#7 @SergeyBiryukov
6 years ago

  • Keywords has-patch commit added

#8 @johnbillion
6 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 28896:

Remove the WordPress logo from the focusable elements on the install/update screens. Fixes #28674. Props stompweb

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 years ago

Note: See TracTickets for help on using tickets.