Opened 10 years ago
Closed 10 years ago
#28675 closed defect (bug) (fixed)
#wpcontent and #wpfooter admin padding and margins
Reported by: | TJNowell | Owned by: | helen |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | ui, administration | Cc: |
Description
The main content and footer wrapper elements in the admin panel have a margin on the left to prevent overlapping with the menu of 180px
This margin includes the padding on the left of the content however. This padding should be added as padding.
Adding this css in the web inspector should demonstrate the issue:
#wpcontent, #wpfooter { background: hotpink; }
To fix this, this css:
#wpcontent, #wpfooter { margin-left: 180px; }
needs to become:
#wpcontent, #wpfooter { margin-left: 160px; padding-left: 20px; }
Attachments (5)
Change History (18)
#1
@
10 years ago
- Keywords has-patch added
I've attached a patch for develop that fixes the issue, and I've added changes to account for the folded menu
#2
@
10 years ago
- Focuses ui added
- Keywords commit added
- Milestone changed from Awaiting Review to 4.0
#3
@
10 years ago
- Keywords needs-patch added; has-patch commit removed
Footer is not quite right with the patch - padding is reset later for #wpfooter
, and also has a margin on the right. Also needs to be checked in RTL, since it's left/right dependent (it's probably fine, but should be checked). Want to re-patch, TJNowell?
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
10 years ago
#8
follow-up:
↓ 9
@
10 years ago
Refreshed 28675.3.diff patch on src folder, reapplied CSS changes and tested with small tweak to padding and margin on footer.
The same changes should be applied to common-rtl.css and admin-menu-rtl.css but they don't seem to be in the src/wp-admin/css folder. Any ideas on why they are not there?
#10
in reply to:
↑ 9
@
10 years ago
Replying to SergeyBiryukov:
Replying to sumobi:
The same changes should be applied to common-rtl.css and admin-menu-rtl.css but they don't seem to be in the src/wp-admin/css folder. Any ideas on why they are not there?
They are auto-generated on commit, see #24977. No need to patch them.
Ahh, good to know, thanks
Screenshot of issue with hotpink on the wpcontent background