Removes Margin from Editor Style as it overrides CSS in editor style

[RDall]

The align center in the editor style wasn't working because their was a line of style in the wp-content.css that was overriding all editor styles.

This should be handled by the editor style and not the TinyMCE style.

[RDall]

emoves Margin and Padding from TinyMCE style editor

[SergeyBiryukov]

Makes sense to me.

[SergeyBiryukov]

Related: #28048

[obenland]

RDall, could you attache before/after screenshots to this ticket?
Which theme's editor stylesheet didn't work?

[RDall]

Hi Obenland It was Twenty Thirteen I was working on when I saw this and I was with Aaron Jorbin at WCSEA contributor day when I saw the issue. He suggested that the style wasn't being applied because it was being overridden by style in the include file.

I will attach screenshots shortly.

[RDall]

Screenshots:

Post view of image:
​http://cl.ly/image/2m211q3G3l0a

Editor view before:
​http://cl.ly/image/2s3S1u1O1A1J

And with the patch applied:
​http://cl.ly/image/013l0D1n1x0u

[obenland]

Okay, that's a Twenty Thirteen bug then, where the editor styles need to be more specific.
A center-aligned caption in _s and Twenty Fourteen is center aligned.

[RDall]

How would you add more weight to the editor style css then? Without using the dreaded !important.

I did find the bug… but Jobin suggested the patch… So I am somewhat at a loss of how to override something core doesn't want to override in a theme…

Suggestions welcome :-)

[SergeyBiryukov]

Replying to obenland:

Okay, that's a Twenty Thirteen bug then, where the editor styles need to be more specific.
A center-aligned caption in _s and Twenty Fourteen is center aligned.

We had to fix it for Twenty Fourteen in [28941]. Twenty Thirteen doesn't have that style and uses the default one.

I think the point of this ticket is that center-aligned images with captions should be displayed correctly in TinyMCE regardless of the theme. Currently, .html5-captions .wp-caption { margin: 0; } in default styles overrides .aligncenter { margin-left: auto; margin-right: auto; }.

[RDall]

After looking at the code and trying a few ideas which didn't work as they were still overridden but the tinyMCE file I can whole heartily agree with Serge in comment and Jorbin in his original idea as it should be applied to all themes regardless.

[obenland]

Replying to SergeyBiryukov:

We had to fix it for Twenty Fourteen in [28941]. Twenty Thirteen doesn't have that style and uses the default one.

I think the point of this ticket is that center-aligned images with captions should be displayed correctly in TinyMCE regardless of the theme. Currently, .html5-captions .wp-caption { margin: 0; } in default styles overrides .aligncenter { margin-left: auto; margin-right: auto; }.

Bummer we didn't catch that in 3.9 :(

But let's make the selector more specific then, rather than removing the style resets.

[RDall]

Patch works for me.

[azaozz]

In 29195:

TinyMCE: fix aligncenter for html5-captions, props obenland, fixes #28681.