Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#28682 closed task (blessed) (fixed)

Live-update the site title in the admin bar when changing the corresponding setting field

Reported by: celloexpressions's profile celloexpressions Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Options, Meta APIs Keywords: has-patch
Focuses: ui, javascript, administration Cc:


Similarly to how #23076 works, for the Settings -> General screen.

Attachments (3)

28682.diff (738 bytes) - added by celloexpressions 10 years ago.
28682.patch (1.0 KB) - added by iseulde 10 years ago.
28682.2.patch (784 bytes) - added by iseulde 10 years ago.

Download all attachments as: .zip

Change History (17)

#1 @celloexpressions
10 years ago

  • Keywords has-patch added

#2 @celloexpressions
10 years ago

Worth noting that this now happens in the Customizer, where the site title is displayed under "You are customizing".

#3 @DrewAPicture
10 years ago

  • Component changed from General to Options, Meta APIs

#4 @celloexpressions
10 years ago

  • Milestone changed from Awaiting Review to 4.1

Should be ready for commit unless anyone has other considerations to bring up. We're doing similar things in the Customizer and in Menus now too.

10 years ago

#5 @iseulde
10 years ago

Should probably cache the queries a bit (you can use this). Refreshed the patch.

#6 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29963:

Live-update site title in toolbar when changing the corresponding field in General Settings.

props celloexpressions, avryl.
fixes #28682.

#7 @nacin
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I just saw this in the wild without knowing about this ticket. I love little details like this. This is really awesome. :-)

  • When your blogname is empty, we show your URL, with protocol and up through www trimmed off. Should we do that here? I deleted my blogname to type it again, and the toolbar was looking sparse.
  • It doesn't handle "My Sites". Does that matter? Is there any reason why it couldn't? (Currently, an empty blogname means we spit out $blog->domain in PHP, which doesn't necessarily makes sense, and we should use the same technique as in the first bullet point, but that should be fixed separately.)

#8 follow-up: @johnbillion
10 years ago

  • Type changed from enhancement to task (blessed)

I think this is a completely pointless change, but meh, whatever.

Should the <title> change at the same time?

#9 @johnbillion
10 years ago

  • Keywords has-patch removed

#10 in reply to: ↑ 8 @nacin
10 years ago

Replying to johnbillion:

I think this is a completely pointless change, but meh, whatever.

One thing that helps separate WordPress from the rest of the pack is the little design details like this. This comes directly from matt's approach to building software, and it's something that markjaquith, helen, koop, and I have pushed especially hard for with every feature we've worked on. It's also really cool that none of us were involved here. These values are instilled deep!

As I said above, I didn't know about this ticket until I randomly saw it in action a week or two after it was committed. But I didn't share what my reaction was — "WHOA! Cool!" As it should be.

For more cool stuff along these lines, see (Incidentally, the latest post on that blog is

10 years ago

#11 @nofearinc
10 years ago

  • Keywords has-patch added

That enhancement is just awesome and 28682.2.patch works for me.

#12 @SergeyBiryukov
10 years ago

In 30597:

When live-updating site title in toolbar, fall back to the site url if the title is empty.

props avryl.
see #28682.

#13 @SergeyBiryukov
10 years ago

In 30598:

Consistently handle an empty site title in Site and My Sites toolbar menus.

see #28682.

#14 @SergeyBiryukov
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

[30598] addresses the $blog->domain issue outlined in comment:7.

I think we can skip live-updating "My Sites" or <title>, and close this as fixed for now.

Note: See TracTickets for help on using tickets.