In inline link modal keyboard command overide browser defaults

[RDall]

Thanks to @jorbin who help me decipher this ticket.

1. Highlight some text and click add link. ​http://cl.ly/image/060M2U351V40
2. The highlighted field is the url field. Click into the Url. ​http://cl.ly/image/0a2w240Q1Y2P
3. Type in a commonly used address that wants to auto complete. ​http://cl.ly/image/3G2r313g2d3s

3a. Click the down arrow and see how the selector doesn't go to the browser auto complete field but the available posts below the search field. ​http://cl.ly/image/3G2r313g2d3s

Can provide screencast if required.

[SergeyBiryukov]

Confirmed. However, I don't think there's an easy way to detect if the browser autocomplete list is open.

[jorbin]

I think what we can detect if the focus is on the input field and it contains information different than either an empty string or the default string ('​http://'), we can infer that the intent is to use the browser autocomplete.

[SergeyBiryukov]

Replying to jorbin:

I think what we can detect if the focus is on the input field and it contains information different than either an empty string or the default string ('​http://'), we can infer that the intent is to use the browser autocomplete.

Yes, but I think the point of this feature is to be able to scroll quickly through existing posts with Up/Down keys, while the URL input is still focused.

[SergeyBiryukov]

Introduced in [16561].

[jorbin]

Replying to SergeyBiryukov:

Replying to jorbin:

I think what we can detect if the focus is on the input field and it contains information different than either an empty string or the default string ('​http://'), we can infer that the intent is to use the browser autocomplete.

Yes, but I think the point of this feature is to be able to scroll quickly through existing posts with Up/Down keys, while the URL input is still focused.

Certainly, the autocomplete feature in the browser also is designed to make it easy to scroll quickly through your (as the users) previously entered information.

We shouldn't be interfering with default browser behavior. It makes it more confusing for users.

[SergeyBiryukov]

An empty value or http:// can trigger autocomplete too.

So I guess a simple solution would be to disable scrolling when URL or Title field is focused, and only keep it for Search field, where we have autocomplete="off".

Related: comment:11:ticket:17101.

[DrewAPicture]

Wow, yeah, that's annoying.

28685.patch​ fixes it for me.

[helen]

In 29301:

Don't interfere with browser-based autocomplete in the link modal. props SergeyBiryukov. fixes #28685.