Opened 11 years ago
Closed 11 years ago
#28690 closed defect (bug) (fixed)
load_plugin_texdomain() PHPDoc doesn't document return value.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 2.8 |
Component: | I18N | Keywords: | |
Focuses: | docs | Cc: |
Description
Since 2.8 (#10286), load_plugin_textdomain()
has had a boolean return value, but it doesn't have the @return
tag documenting this in its docblock. (Prior to 2.8, it did not return a value.)
Attachments (2)
Change History (10)
#3
@
11 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 28924:
#4
in reply to:
↑ 2
@
11 years ago
- Keywords needs-patch added; has-patch removed
- Resolution fixed deleted
- Status changed from closed to reopened
Replying to SergeyBiryukov:
We didn't add
@since
for otherload_*_textdomain()
functions in [25458], so I guess it's not necessary here.
We probably should have, especially since we're working so hard to make sure our docs are as complete as possible these days :)
This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.
11 years ago
#6
follow-up:
↓ 8
@
11 years ago
Given this dates to 2.8, I don't think it's worth trying to go back in time to document changes made long ago. If we're going to do that, we're gonna want to do it for everything.
#8
in reply to:
↑ 6
@
11 years ago
- Keywords needs-patch removed
- Resolution set to fixed
- Status changed from reopened to closed
Replying to nacin:
Given this dates to 2.8, I don't think it's worth trying to go back in time to document changes made long ago. If we're going to do that, we're gonna want to do it for everything.
Yeah, that's what I thought.
Related: [11680], [25458].
We didn't add
@since
for otherload_*_textdomain()
functions in [25458], so I guess it's not necessary here.