Change to multisite's bootstrap causes undefined functions

[Ipstenu]

I updated a theme and ended up with a WSoD, and also found that running commands (esp. on wp-cli) netted me this:

Fatal error: Call to undefined function ms_subdomain_constants() in /home/ipstenu/public_html/wp-includes/ms-settings.php on line 18

I traced it back to this changeset: [28910]

When I reverted the changes to /wp-includes/ms-settings.php then everything worked again.

If I only reverted the default constants, I got this:

Fatal error: Call to undefined function get_site_by_path() in /home/ipstenu/public_html/wp-includes/ms-settings.php on line 56

Apparently things aren't being loaded soon enough for Multisite?

Tested on latest SVN. No errors on 3.9.1

[jeremyfelt]

I was wondering if this could happen.

I think this would only occur if ms-settings.php was being included outside of the normal wp-settings.php process. I'm not yet sure when that would happen, but I'll dig. Any plugins or themes or sunrises involved?

[jeremyfelt]

It looks like half of this is WP-CLI needing to be updated to match the new boot as of [28910] in ​wp-settings-cli.php.

[ocean90]

So you have updated the theme through WP-CLI?

[Ipstenu]

jeremyfelt: No sunrise.

ocean90: No, I did not use wp-cli to update the theme. I used wp-cli when I tried to go in after the WSOD.

1) Update theme the normal way
2) See WSoD
3) Go to wp-cli to disable theme
4) Error

[jeremyfelt]

I went through a theme upgrade with 2 themes (Parallax and Semicolon) just now and was not able to reproduce the WSOD issue on the admin or front end. I don't have a sunrise or any plugins setup and this was with a freshly converted subdomain multisite installation.

[Ipstenu]

I'm confident the WSoD was a failed install now. Reinstalled the theme, no problems.

[SergeyBiryukov]

Sounds like wp-settings.php was not updated on that install.

Anything we need to do here?

[Ipstenu]

I've pinged Shredder about WPCLI :) Though Daniel's here so he knows too now :D

I'll keep an eye on the oddities. I've force updated WP to svn trunk and it seems to be okay now.

[SergeyBiryukov]

Fixed in [28934].