WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#28703 closed defect (bug) (fixed)

Table class in Twenty Fourteen editor-style.css need to be updated

Reported by: slobodanmanic Owned by: lancewillett
Priority: normal Milestone: 4.1
Component: Bundled Theme Version: 3.9
Severity: normal Keywords: has-patch
Cc: Focuses: administration

Description

I guess this happened in 3.9, when TinyMCE was updated, but can't find it in TinyMCE changelog.

.mceItemTable is not being generated any more and is replaced by .mce-item-table

If they changed the format it would be good to also update .mceContentBody class to .mce-content-body, currently they're both used.

Might be best not to use this class at all, but when table is used instead, table borders get messed up, so I'm guessing it was added to override that.

Attachments (2)

28703.diff​ (826 bytes ) - added by slobodanmanic 12 years ago.
28703-1.diff​ (870 bytes ) - added by slobodanmanic 12 years ago.

Download all attachments as: .zip

Change History (9)

@slobodanmanic
12 years ago

#1 @slobodanmanic
12 years ago

Patch replaces the class used for tables.

#2 @chriseverson
12 years ago

  • Keywords has-patch added

#3 @DrewAPicture
12 years ago

  • Component General → Bundled Theme

#4 follow-up: @SergeyBiryukov
12 years ago

Should we keep the old class for backwards compatibility with 3.8.x?

#5 in reply to: ↑ 4 @slobodanmanic
12 years ago

Replying to SergeyBiryukov:

Should we keep the old class for backwards compatibility with 3.8.x?

Good point. I'll update new patch in about an hour.

@slobodanmanic
12 years ago

#6 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution → fixed
  • Status new → closed

In 30147:

Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names.

Props slobodanmanic, fixes #28703.

#7 @lancewillett
12 years ago

  • Milestone Awaiting Review → 4.1
Note: See TracTickets for help on using tickets.