WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#28706 closed defect (bug) (fixed)

Lots of Multisite tests are exploding

Reported by: wonderboymusic Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:
PR Number:

Description

I shall fix them.

Change History (12)

#1 @wonderboymusic
6 years ago

In 28960:

URLs in unit tests need to be generated, not hard-coded.

See #28706.

#2 @wonderboymusic
6 years ago

In 28961:

test_wp_get_shortlink() assumes permalink structure is when it starts. It is not.

See #28706.

Last edited 6 years ago by wonderboymusic (previous) (diff)

#3 @wonderboymusic
6 years ago

In 28962:

This test in post/revisions.php is too misleading and doesn't work as expected since multiple queries can occur before the one that is intended for testing.

See #28706.

#4 @wonderboymusic
6 years ago

In 28964:

Make sure hundreds of canonical tests don't fail in multisite every other time they are run.

See #28706.

#5 @wonderboymusic
6 years ago

In 28965:

Transient timeouts are untestable when WP_INSTALLING is defined and set to ANY value. Transient timeouts cannot be tested during multisite runs because wpmu_create_blog() sets WP_INSTALLING. I have zero idea how these tests ever passed.

See #28706.

#6 @wonderboymusic
6 years ago

In 28966:

Setup rewrite changes in tests in a predictable fashion. Don't mix method calls with wrapper function calls.

See #28706.

#7 @wonderboymusic
6 years ago

In 28967:

Make sure permalink structure is consistent when running query tests.

See #28706.

#8 @wonderboymusic
6 years ago

In 28968:

URLs need to be generated, not hard-coded, in user/listAuthors.php test.

See #28706.

#9 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

All unit tests pass - 300 were previously failing.

#10 @jeremyfelt
6 years ago

Related #27704, fixed as part of this effort.

#11 @SergeyBiryukov
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

See #28738.

#12 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from reopened to closed

In 28988:

Bring back define( 'WP_INSTALLING', true ); in phpunit/includes/install.php, which was removed in [28965]. tl;dr = wp-cli. Unit tests still pass in multisite because of the skips I added.

Fixes #28738, #28706.

Note: See TracTickets for help on using tickets.