WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#28718 closed defect (bug) (fixed)

Curly Quotes Should Work Like <"this">

Reported by: miqrogroove's profile miqrogroove Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 2.9
Component: Formatting Keywords: has-patch wptexturize
Focuses: Cc:

Description

When I first started working on the unit tests for 3.9, I noticed the curly quotes patterns were incorrectly searching for unencoded angle brackets < and >. For this to work correctly, the patterns need to match &lt; and &gt; instead.

Bug introduced at [11813].

Attachments (3)

miqro-28718.patch​ (7.5 KB) - added by miqrogroove 11 years ago.
miqro-28718.2.patch​ (7.5 KB) - added by miqrogroove 11 years ago.
Typo in test_quotes_before_numbers()
miqro-28718.3.patch​ (8.0 KB) - added by miqrogroove 11 years ago.
Missed a test in test_opening_quote()

Download all attachments as: .zip

Change History (7)

@miqrogroove
11 years ago

#1 @miqrogroove
11 years ago

  • Keywords has-patch wptexturize added

@miqrogroove
11 years ago

Typo in test_quotes_before_numbers()

#2 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 4.0

This ticket was mentioned in IRC in #wordpress-dev by SergeyBiryukov. ​View the logs.
11 years ago

@miqrogroove
11 years ago

Missed a test in test_opening_quote()

#4 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 28971:

Fix texturization of quotes when enclosed by angle brackets.

props miqrogroove.
fixes #28718.

Note: See TracTickets for help on using tickets.