Opened 10 years ago
Closed 10 years ago
#28741 closed defect (bug) (invalid)
When opening up a modal the overlay will block ( via zindex ) modals from working
Reported by: | hemstreet | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | trivial | Version: | 3.9 |
Component: | Administration | Keywords: | reporter-feedback close |
Focuses: | ui, accessibility, administration | Cc: |
Description
The modal has been hidden by an underlay located in thickbox.css. The z-index was to high and would hide the modal during the plugin details modal
Attachments (1)
Change History (8)
#1
@
10 years ago
- Component changed from General to Administration
- Severity changed from normal to major
- Summary changed from Modal hiding behind underlay in plugin details to Modal while viewing plugin details link will hide behind overlay making the modal rendered useless
#3
in reply to:
↑ description
;
follow-up:
↓ 5
@
10 years ago
- Focuses administration added
- Severity changed from major to critical
- Summary changed from Modal while viewing plugin details link will hide behind overlay making the modal rendered useless to When opening up a modal the overlay will block ( via zindex ) any modals from working
Replying to hemstreet:
The modal has been hidden by an underlay located in thickbox.css. The z-index was to high and would hide the modal during the plugin details modal
Found a few more cases in which this patch will fix. This is now leading me to believe that all Overlays in the wordpress admin area are now being blocked
http://cl.ly/image/1S303S140d31
http://cl.ly/image/0Q000K1Z1U1U
http://cl.ly/image/38411f1D060b/o
#4
in reply to:
↑ description
@
10 years ago
- Severity changed from critical to trivial
- Summary changed from When opening up a modal the overlay will block ( via zindex ) any modals from working to When opening up a modal the overlay will block ( via zindex ) modals from working
Replying to hemstreet:
The modal has been hidden by an underlay located in thickbox.css. The z-index was to high and would hide the modal during the plugin details modal
#5
in reply to:
↑ 3
@
10 years ago
- Keywords reporter-feedback added
Replying to hemstreet:
Found a few more cases in which this patch will fix. This is now leading me to believe that all Overlays in the wordpress admin area are now being blocked
I see the issue on the screenshots, but I'm not sure how to reproduce it. The plugin details link works as expected for me in current trunk.
Does it still happen with all plugins disabled and a default theme (Twenty Fourteen or Twenty Thirteen) activated?
#6
@
10 years ago
- Keywords close added
- Version changed from trunk to 3.9
I can't reproduce either.
The thickbox overlay and the thickbox modal (which is what you're seeing in all of your screenshots) have the same index, and your patch changes both of them, which wouldn't have any effect on the modal displaying in front of the overlay. The modal element is after the overlay, which is why it's always displayed on top of the overlay when they have the same index. Changing the z-index
here would cause issues with the overlay and modal displaying behind other elements of the admin, as noted in the css inline comments, and shouldn't fix the issue you're seeing. Most likely there's a plugin conflict.
#7
@
10 years ago
- Milestone Awaiting Review deleted
- Resolution set to invalid
- Status changed from new to closed
Also can't reproduce this; can the reporter provide feedback if there's something we're all missing? If your test environment is clean, then this could still be a real issue.
Feel free to re-open if you think it's valid, but I'm closing.
Plugin details modal underlay fix