clean_term_cache does not obey wp_suspend_cache_invalidation

[rmccue]

If you call wp_suspend_cache_invalidation( true ), then use wp_insert_term, clean_term_cache still clears the cache for the taxonomy.

This is in contrast to clean_post_cache and clean_attachment_cache

[tollmanz]

I added a patch for this in #21760. It's strongly tied to the work being done in that ticket, so I thought it belonged there.

[goblindegook]

Oh good, I came here to report just this bug!

I'm in the process of upserting around 50K posts and running into severe memory issues whenever I run wp_update_term() because the clean_object_term_cache() call in there still pointlessly loops through every single object with the term. You have to check wp_suspend_cache_invalidation() _before_ going into that foreach chain.

[boonebgorges]

Duplicate of #21760.

This was added in [29915]. Going to close this one as a duplicate.

[johnbillion]

In 30592:

Revert [30032] so appropriate PHP warnings aren't masked.

Fixes #28743

[boonebgorges]

[29915] was reverted, so I think we should reopen this ticket and consider it as a separate enhancement.

[boonebgorges]

In 32498:

Respect $_wp_suspend_cache_invalidation in clean_term_cache().

Props tollmanz, rmccue.
Fixes #28743.