![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 12 years ago
Closed 8 years ago
#28753 closed enhancement (maybelater)
Use reusable consistent CSS for the theme and plugin uploader
| Reported by: | paulwilde | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Upload | Version: | 4.0 |
| Severity: | normal | Keywords: | ui-feedback needs-refresh needs-screenshots |
| Cc: | Focuses: | ui, javascript |
Description
The theme uploader introduced a new look in 3.8. This patch gives the file upload container a more generic reusable class and I've added it to plugin upload for consistency between the views.
Attachments (15)
Change History (47)
#3
@
12 years ago
Indeed, was thinking the same. The Media Library could also have it too with it's multi-upload specific UI.
#4
@
12 years ago
- Keywords dev-feedback added
28753.3.diff does the following:
- Use the same consistent styling between the theme/plugin uploaders.
- Removes the "Upload" tab and move it beside the title. Clicking the title button will toggle the upload frame on any of the tabs you are currently viewing.
- Removes plugin-install.js in favour of plugin.js.
- plugin.js includes the code previously in plugin-install.js and the Backbone to handle routing/toggling the upload button. I've never used backbone before so this code might be a little off.
#6
@
12 years ago
Nice work paulwilde. Would be good to unify the Media uploaders, too. Currently they have different design
This ticket was mentioned in IRC in #wordpress-dev by michalzuber. View the logs.
12 years ago
#9
@
12 years ago
Rewrote paulwilde's diff, thank you paulwilde.
Results http://i.imgur.com/Y8LqW8s.png & http://i.imgur.com/P6HziVc.png
@
12 years ago
Fixed Uncaught ReferenceError: _wpPluginSettings is not defined plugin-install.js?ver=4.0-beta1-src:10
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
12 years ago
#11
follow-up:
↓ 12
@
12 years ago
- Keywords needs-refresh added; dev-feedback removed
We can do the styling part from the first patch - no Backbone explorations right now, please. I also don't love that we do a display: block on something with "hidden" in the class name. Would rather toggle something else.
#12
in reply to: ↑ 11
;
follow-up:
↓ 13
@
12 years ago
- Keywords needs-refresh removed
Replying to helen:
We can do the styling part from the first patch - no Backbone explorations right now, please. I also don't love that we do a
display: blockon something with "hidden" in the class name. Would rather toggle something else.
Updated 28753.6.diff.
Helen I need feedback about adding filter bar above the upload form in Add themes http://i.imgur.com/Y689NpO.png as Install Plugins have http://i.imgur.com/IwydnwA.png
#13
in reply to: ↑ 12
@
12 years ago
Replying to michalzuber:
I need feedback about adding filter bar above the upload form in Add themes
No opinion right now. Don't really want to touch it for 4.0.
Patch looks incomplete - doesn't remove the original CSS, doesn't alter markup for themes. I just don't want to dabble in Backbone for plugins. Also note that we put a newline above each ruleset in CSS - there are some inconsistencies, particularly in themes.css, so I can see why they get left out in people's patches sometimes.
#14
@
12 years ago
drawer-grouping-2.diff:
- Renames 'wp-filter-group-wide' to 'wp-filter-group-2-5' to be more understandable as a grid column. Also added 1-5, 3-5 and 4-5.
- Utilises calc to ensure that the groups have consistent spacing rather than having a bigger gap on the right side.
#15
@
12 years ago
Opps. My above patch (drawer-grouping-2.diff) was meant for #28794. I've gone ahead of reposted it there.
upload.diff does the following different from my previous patch:
- Removes all the Backbone stuff.
- Uses
.wp-upload-container-toggleinstead of.wp-upload-container-hiddenfor the Themes uploader.
#16
@
12 years ago
We could use ericlewis's code from https://core.trac.wordpress.org/ticket/28851
This ticket was mentioned in IRC in #wordpress-dev by michalzuber. View the logs.
12 years ago
#20
@
12 years ago
- Keywords commit added
28753-upload-container.patch is build on upload.diff. Additionally it hides .wp-filter on plugin upload screen and switches .add-new-h2 buttons, same as for themes.
#21
@
12 years ago
- Keywords commit removed
Latest patch causes some weirdness on the plugins upload screen. Also, I'm really not feeling the look of it. I know it comes from themes, but that doesn't make it an automatic okay to adopt across the admin.
This ticket was mentioned in IRC in #wordpress-dev by ocean90. View the logs.
12 years ago
#24
@
12 years ago
- Milestone 4.0 → Future Release
Punting. Really not loving the way the themes one is styled - we need to make a unified decision, not just unify around something. Design attention would be lovely.
#25
@
12 years ago
- Keywords punt removed
Related: [29634] – "Use the same nice design for the plugin upload screen as the theme upload screen."
This ticket was mentioned in Slack in #design by karmatosed. View the logs.
9 years ago
#29
@
9 years ago
- Keywords needs-refresh needs-screenshots added; needs-patch removed
Can we get some screenshots of the latest patch on this?
Looks good! Related, we should think about making the header area consistent between theme and plugin uploading as well: https://cloudup.com/ilT84tTVWSv