Permalinks Options/Notices on nginx + HHVM incorrect

[crxgames]

The permalink settings page in the admin panel is incorrect when running Wordpress under HHVM + nginx. index.php is always included in the permalink samples and the notice messages are those from Apache.

This patch adds a new global, $is_hhvm, in the same fashion nginx is tested for, and updates the permalinks settings page accordingly.

[johnbillion]

Thanks for the report crxgames.

Interesting that HHVM doesn't pass the web server name through to $_SERVER['SERVER_SOFTWARE']. I would have expected it to pass through 'nginx' if I'm running Nginx.

What happens if you're running HHVM behind Apache instead of Nginx? The return value of got_url_rewrite() will return true even if got_mod_rewrite() returns false. (Granted, if you're running HHVM you're unlikely to be running Apache without mod_rewrite, but the point still stands.)

[crxgames]

So, should we report this as an HHVM issue instead of include a work around for it perhaps?

[johnbillion]

This was ​fixed in HHVM 3.6.1.