![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 12 years ago
Closed 11 years ago
#28766 closed enhancement (invalid)
Permalinks Options/Notices on nginx + HHVM incorrect
| Reported by: | crxgames | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Permalinks | Version: | 3.9 |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: | Focuses: |
Description
The permalink settings page in the admin panel is incorrect when running Wordpress under HHVM + nginx. index.php is always included in the permalink samples and the notice messages are those from Apache.
This patch adds a new global, $is_hhvm, in the same fashion nginx is tested for, and updates the permalinks settings page accordingly.
Attachments (1)
Change History (5)
#2
@
12 years ago
- Focuses administration removed
- Keywords has-patch needs-testing added
- Milestone Awaiting Review → Future Release
- Type defect (bug) → enhancement
#3
@
12 years ago
So, should we report this as an HHVM issue instead of include a work around for it perhaps?
#4
@
11 years ago
- Milestone Future Release
- Resolution → invalid
- Status new → closed
This was fixed in HHVM 3.6.1.
Note:
See TracTickets
for help on using tickets.
Thanks for the report crxgames.
Interesting that HHVM doesn't pass the web server name through to
$_SERVER['SERVER_SOFTWARE']. I would have expected it to pass through 'nginx' if I'm running Nginx.What happens if you're running HHVM behind Apache instead of Nginx? The return value of
got_url_rewrite()will return true even ifgot_mod_rewrite()returns false. (Granted, if you're running HHVM you're unlikely to be running Apache without mod_rewrite, but the point still stands.)