WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #28785, comment 7


Ignore:
Timestamp:
07/08/14 14:37:01 (3 years ago)
Author:
stephdau
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28785, comment 7

    initial v1  
    11I wanted to play and see if I could set the banner as a very subtle background for the plugin-card div, when available (maybe with a white overlay, opacity 0.4 or so, to diffuse it). I don't see banners being returned as part of the query results yet though. 
    22 
    3 Wouldn't always work IRL though, since plugins devs actually layout some info i their banners, sometimes, and expect the banner to be displayed in full. To be fair, they'll have to get used to not being able to do this in the future though, because said banners will now be displayed in a multitude of contexts (maybe here, in modal, on wp.org, etc). It's unlikely to be viable to ask them to provide [n] different banner sizes, all with different aspect ratios. It also "limits" our ability to play with designs (if we try to guarantee banners will be displayed in full, precisely). 
     3Wouldn't always work IRL though, since plugins devs actually layout some info in their banners sometimes, and expect the banner to be displayed in full. To be fair, they'll have to get used to not being able to do this in the future though, because said banners will now be displayed in a multitude of contexts (maybe here, in modal, on wp.org, etc). It's unlikely to be viable to ask them to provide [n] different banner sizes, all with different aspect ratios. It also "limits" our ability to play with designs (if we try to guarantee banners will be displayed in full, precisely). 
    44 
    55Wadya think?