Opened 9 years ago
Closed 9 years ago
#28788 closed defect (bug) (fixed)
wpviews: whenever a view is updated or inserted, all the views are refreshed
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 3.9 |
Component: | TinyMCE | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description
This is pretty bad for views that take a long time to load. It's not necessary at all to refresh *all* the views.
Attachments (2)
Change History (10)
This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.
9 years ago
#4
@
9 years ago
- Keywords reporter-feedback added
Are you still planning to work up a patch for this Janneke?
#6
@
9 years ago
- Keywords has-patch added; needs-patch removed
So the current problem: whenever you insert a view, paste a view or edit a view, every single view re-renders. For paste it's even worse. Whenever you paste *anything*, every single view re-renders. If it's just a gallery, it's not that annoying, but it there are iframes to load, it's very visible and annoying.
With the patch the render function check whether or not all the viewnodes for a particular instance have been rendered before. One unrendered view for that instance (which means that there are more of the same shortcodes in the editor) triggers rendering for all the viewnodes in that instance, but not all the viewnodes.
I also updated the refreshView function so that only the viewnodes for that instance are refreshed.
Hi Janneke, is this still an issue? Do we need a patch here?