WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#28794 closed enhancement (fixed)

Use reusable OOCSS for the filter bar on the Add Themes page

Reported by: paulwilde Owned by: helen
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Themes Keywords:
Focuses: Cc:

Description

The attached patch refactors .theme-navigation to use a generic .wp-filter for all CSS selectors/JS hooks on the Add Themes page to increase reusability such as for use with the media grid in 4.0 rather than having to duplicate the styling.

I've also added a reusable .wp-title-count inside common.css which shows a count of themes used on wp-admin/themes.php.

Attachments (4)

28794.diff (28.5 KB) - added by paulwilde 6 years ago.
drawer-grouping-2.diff (2.9 KB) - added by paulwilde 6 years ago.
theme-groups-before.png (518.3 KB) - added by paulwilde 6 years ago.
theme-groups-after.png (518.4 KB) - added by paulwilde 6 years ago.

Download all attachments as: .zip

Change History (7)

@paulwilde
6 years ago

#1 @helen
6 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 29217:

Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794.

#2 @helen
6 years ago

  • Milestone changed from Awaiting Review to 4.0

#3 @paulwilde
6 years ago

drawer-grouping-2.diff:

  • Renames 'wp-filter-group-wide' to 'wp-filter-group-2-5' to be more understandable as a grid column. Also added 1-5, 3-5 and 4-5.
  • Utilises calc to ensure that the groups have consistent spacing rather than having a bigger gap on the right side.
Note: See TracTickets for help on using tickets.