WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#28803 closed defect (bug) (fixed)

Audit screen options for new plugin "cards"

Reported by: paulwilde Owned by: ocean90
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Plugins Keywords: has-patch commit
Focuses: ui Cc:

Description

After #28785 checking the "Version" option inside Screen Options does not toggle anything on the new Plugin Cards, whereas toggling "Rating" and "Description" does.

Maybe a couple of extra toggles could also be added? Toggling the Rating seems somewhat useless at the moment as you do not lose any vertical space due to the other content inside the footer. Maybe being able to toggle the entire footer would make more sense?

Attachments (4)

screen-options.png (281.5 KB) - added by paulwilde 3 years ago.
28803.diff (1.0 KB) - added by paulwilde 3 years ago.
28803.2.diff (465 bytes) - added by DrewAPicture 3 years ago.
remove screen options
28803.3.diff (2.0 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (13)

#1 @paulwilde
3 years ago

My patch on #28673 removes the unused "Version" and adds an "Extra Details" toggle which hides the plugin card footers.

@paulwilde
3 years ago

#2 @paulwilde
3 years ago

I've attached a patch which removes the "Version" Screen Option as it doesn't do anything and adds another called "Extra Details" which toggles the footer of the plugin card (see the above screenshot as reference what it looks like with "Extra Details" disabled).

Last edited 3 years ago by paulwilde (previous) (diff)

#3 @paulwilde
3 years ago

  • Keywords has-patch added

#4 @celloexpressions
3 years ago

  • Milestone changed from Awaiting Review to 4.0

I'd suggest removing the screen options for plugin-install entirely. Since this display is more visual than what we had previously, and displays the same information in a more condensed form, I don't see much benefit to hiding the different options regardless of use-case. As it is, toggling description or ration doesn't save any notable vertical space.

#5 @helen
3 years ago

Agree, I see no reason for there to be options here.

#6 @celloexpressions
3 years ago

  • Keywords needs-patch added; has-patch removed

@DrewAPicture
3 years ago

remove screen options

#7 @DrewAPicture
3 years ago

  • Keywords has-patch commit added; needs-patch removed

28803.2.diff hides the screen options for plugin-install.php.

@ocean90
3 years ago

#8 @ocean90
3 years ago

28803.3.diff removes the columns and so the screen options.

#9 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 29498:

Plugin install: Remove columns and screen options.

fixes #28803.

Note: See TracTickets for help on using tickets.