WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#28805 closed enhancement (fixed)

File upload support for Adobe Photoshop PSD

Reported by: michalzuber Owned by: ccprice
Milestone: 4.1 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: needs-patch good-first-bug
Focuses: Cc:

Description

I was adding a PSD file over Add media of P2 theme and after uploading the 24MB I got Error: filetype is not permitted

http://i.imgur.com/WOuQZYs.png

PHPMailer has support for it:

wp-includes/class-phpmailer.php:2859:            'psd' => 'application/octet-stream',

I should be notified before uploading that the MIME type is not permitted or am I wrong?

Attachments (2)

28805.diff (2.6 KB) - added by michalzuber 5 years ago.
Added mime for PSD
28805.2.diff (1.4 KB) - added by ccprice 5 years ago.

Download all attachments as: .zip

Change History (9)

@michalzuber
5 years ago

Added mime for PSD

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to Media

#2 @michalzuber
5 years ago

  • Keywords dev-feedback has-patch added
  • Version set to trunk

#3 @helen
5 years ago

  • Type changed from defect (bug) to enhancement
  • Version changed from trunk to 3.9

Hard to tell what's going on in the patch with all the whitespace changes. It looks kind of weird originally, too. Trying to align those things with spaces seems like a pretty terrible idea for upkeep.

#4 @wonderboymusic
5 years ago

  • Keywords needs-patch good-first-bug added; dev-feedback has-patch removed
  • Milestone changed from Awaiting Review to 4.1

This patch needs to be rewritten

#5 @wonderboymusic
5 years ago

  • Owner set to ccprice
  • Status changed from new to assigned

@ccprice
5 years ago

#6 @wonderboymusic
5 years ago

Patch looks good, application/octet-stream is what PHPMailer uses, so should suffice for now. Seems like several other possibilities are listed when I search the web.

#7 @wonderboymusic
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 29833:

Allow PSDs (Photoshop documents) to be uploaded.

Props michalzuber, ccprice.
Fixes #28805.

Note: See TracTickets for help on using tickets.