Context Navigation

← Previous Ticket
Next Ticket →

#28810 closed defect (bug) (fixed)

is_active_widget() should skip orphaned widgets

Reported by:	Ninos Ego	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	4.0
Component:	Widgets	Version:	2.8
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

The function is_active_widget() should also skip orphaned widgets. Orphaned widgets are also inactive widgets.

Attachments (2)

widgets.php.patch (562 bytes ) - added by Ninos Ego 12 years ago.
widgets.php.2.patch (563 bytes ) - added by Ninos Ego 12 years ago.: substr instead of strpos

Download all attachments as: .zip

Change History (8)

@Ninos Ego
12 years ago

Attachment widgets.php.patch added

#1 @Ninos Ego
12 years ago

Keywords has-patch added

#2 @Ninos Ego
12 years ago

Severity normal → major

#3 @westonruter
12 years ago

Version trunk → 2.8

Yeah, this makes sense. Minor points: we should use triple-equals, and substr as used elsewhere to check for orphaned_widgets:

( 'wp_inactive_widgets' === $sidebar || 'orphaned_widgets' === substr( $sidebar, 0, 16 ) )

Why was the severity changed to major?

#4 @SergeyBiryukov
12 years ago

Milestone Awaiting Review → 4.0
Severity major → normal

@Ninos Ego
12 years ago

Attachment widgets.php.2.patch added

substr instead of strpos

#5 @Ninos Ego
12 years ago

Sry because of the severity, it was a mistake. I've uploaded the ne patch. Should be ok now.

#6 @SergeyBiryukov
12 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 29064:

is_active_widget() should skip orphaned widgets.

props Ninos Ego.
fixes #28810.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#28810 closed defect (bug) (fixed)

is_active_widget() should skip orphaned widgets

Description

Attachments (2)

Change History (8)

@Ninos Ego 12 years ago

#1 @Ninos Ego 12 years ago

#2 @Ninos Ego 12 years ago

#3 @westonruter 12 years ago

#4 @SergeyBiryukov 12 years ago

@Ninos Ego 12 years ago

#5 @Ninos Ego 12 years ago

#6 @SergeyBiryukov 12 years ago

Download in other formats:

@Ninos Ego
12 years ago

#1 @Ninos Ego
12 years ago

#2 @Ninos Ego
12 years ago

#3 @westonruter
12 years ago

#4 @SergeyBiryukov
12 years ago

@Ninos Ego
12 years ago

#5 @Ninos Ego
12 years ago

#6 @SergeyBiryukov
12 years ago