Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28819 closed defect (bug) (fixed)

Editing Media hangs from media library page in Grid View

Reported by: ipstenu's profile Ipstenu Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: major Version: 4.0
Component: Media Keywords: has-patch commit
Focuses: Cc:



When you're in grid view of the media library and you edit an image, the new modal box will hang on save, with a spinning icon, instead of properly closing. Should you close the media box, the image will actually be saved as changed!

Attachments (1)

28819.diff (1.1 KB) - added by ericlewis 10 years ago.

Download all attachments as: .zip

Change History (9)

#1 @Ipstenu
10 years ago

  • Severity changed from normal to major

On delete from grid view, it also doesn't change the view. It prompts you and asks if you're sure, hit okay, and then nothing. If I close out the modal, it is correctly deleted.

#2 @Ipstenu
10 years ago

The edit issue is resolved. The DELETE issue is not.

#3 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.0

10 years ago

#4 @ericlewis
10 years ago

in attachment:28819.diff, close the modal if the attachment is deleted.

#5 @SergeyBiryukov
10 years ago

#29057 was marked as a duplicate.

#6 @SergeyBiryukov
10 years ago

  • Keywords has-patch commit added

28819.diff works for me.

#7 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29322:

Media Grid: Close the modal if the attachment is deleted.

props ericlewis.
fixes #28819.

#8 @wonderboymusic
10 years ago

In 29427:

Media Grid: remove some unused Trash/Delete handler logic. Rendered useless since [29266] and made official by [29322].

See #28819.

Note: See TracTickets for help on using tickets.