Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#28829 closed enhancement (wontfix)

Updating admin-bar.php for coding standards

Reported by: welcher's profile welcher Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.0
Component: Toolbar Keywords:
Focuses: administration Cc:

Description

This is my first ticket/patch so please let me know if I am not adhering to the correct process. I was looking into #28569 and noticed that there were some if statements that didn't have braces so I added them.

Attachments (1)

28829.diff (9.4 KB) - added by welcher 11 years ago.
admin-bar.php with if statement braces added

Download all attachments as: .zip

Change History (4)

@welcher
11 years ago

admin-bar.php with if statement braces added

#1 follow-up: @SergeyBiryukov
11 years ago

  • Component changed from General to Toolbar
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Please note that formatting cleanup tickets are generally discouraged. Coding style fixes should be a result of more substantial changes: http://wpdevel.wordpress.com/2011/03/23/code-refactoring/. But thanks for the patch!

#2 in reply to: ↑ 1 ; follow-up: @welcher
11 years ago

Replying to SergeyBiryukov:

Please note that formatting cleanup tickets are generally discouraged. Coding style fixes should be a result of more substantial changes: http://wpdevel.wordpress.com/2011/03/23/code-refactoring/. But thanks for the patch!

Thanks for letting me know - I'll do some actual work next time :)

#3 in reply to: ↑ 2 @DrewAPicture
11 years ago

Replying to welcher:

Replying to SergeyBiryukov:

Please note that formatting cleanup tickets are generally discouraged. Coding style fixes should be a result of more substantial changes: http://wpdevel.wordpress.com/2011/03/23/code-refactoring/. But thanks for the patch!

Thanks for letting me know - I'll do some actual work next time :)

It's definitely "actual work" to make updates like this, so thank you for the patch just the same. The reasoning behind only updating for coding standards when the lines would be changing anyway is to reduce undue churn in the codebase, that's all :)

If you're interested in contributing in ways similar to this, the docs team does accept patches that fix inline documentation in WordPress core. See #25412 for a recent example of this.

Note: See TracTickets for help on using tickets.