WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#28831 closed defect (bug) (fixed)

installation interface language doesn't include Simplified Chinese

Reported by: wpchina.org Owned by: nacin
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: I18N Keywords:
Focuses: ui Cc:

Description

The WordPress 4.0 beta1 has been released just now. I tested it and found a problem. The installation interface doesn't include Simplified Chinese.

Chinese is included, but it is Traditional Chinese, which used in Taiwan, Hang Kong etc. People in China mainland use Simplified Chinese.

I can translate the interface language into simplified Chinese before the release date of WordPress 4.0. Just tell me what should I do.

Thank you.

Attachments (1)

28831.patch (2.1 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (14)

#1 @samuelsidler
7 years ago

  • Milestone changed from Awaiting Review to 4.0

Pretty sure this is already on @nacin's radar, as part of #28577. Right now we only have one locale per language, but he's working on fixing that.

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


7 years ago

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


7 years ago

#4 @DrewAPicture
7 years ago

  • Owner set to nacin
  • Status changed from new to reviewing

@nacin: Would you mind taking a look at this?

#5 @ocean90
7 years ago

Looking at https://glotpress.trac.wordpress.org/browser/trunk/locales/locales.php

There are currently five languages related to Chinese. Four of them have the same native code _and_ the same ISO codes. This seems to be a problem, because the ISO codes are used as a key, see https://meta.trac.wordpress.org/browser/sites/trunk/api.wordpress.org/public_html/translations/lib.php#L76

#7 follow-ups: @SergeyBiryukov
7 years ago

Same problem with "English (Australia)", "English (Canada)", and "English (UK)": only the latter makes it to the list.

Looks like we can't use ISO codes as array keys without inadvertently skipping some languages, and should probably use locale slugs instead (or in addition), which are unique.

wp_get_available_translations_from_api() uses language field as a key, which appears to be wp_locale.

28831.patch is a patch for the API. No core changes are needed (I think).

#8 in reply to: ↑ 7 @netweb
7 years ago

Replying to SergeyBiryukov:

Same problem with "English (Australia)", "English (Canada)", and "English (UK)": only the latter makes it to the list.

Related: #28730 Installing British English language files removes the ability to select American English on Multisite

#9 in reply to: ↑ 7 ; follow-up: @ocean90
7 years ago

Replying to SergeyBiryukov:

28831.patch is a patch for the API. No core changes are needed (I think).

I think we have to display the english name too, because otherwise have 4 entries with the same native name.

#10 in reply to: ↑ 9 @helen
7 years ago

Replying to ocean90:

I think we have to display the english name too, because otherwise have 4 entries with the same native name.

Looked at how some family members use computers in Chinese - it is typically listed as "Chinese (Simplified)" vs. "Chinese (Traditional)" in English, "简体中文" vs. "繁體中文" in Chinese. I think we should just have those two listed, which I think are currently Chinese/Chinese (China) and Chinese (Taiwan).

In terms of the GlotPress locale file: The one for Hong Kong has Hong Kong in the Chinese name, not sure if Singapore should do the same, the Taiwan one is traditional (per above), and the one that's just labeled "Chinese" should probably indicate if it's traditional or simplified given that it's about written language.

This ticket was mentioned in IRC in #wordpress-dev by ocean90. View the logs.


7 years ago

#12 @nacin
7 years ago

This is fixed on the API side in [meta812]. Once I rebuild packages for RC1, there will be a simplified Chinese package.

I have made a comment at https://glotpress.trac.wordpress.org/ticket/342#comment:18 with regards to the naming of the Chinese variants.

We should probably enforce in the API not to serve multiple languages with the same native name (or english name, for that matter). They need to be differentiated somehow.

#13 @nacin
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.