WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#28834 closed defect (bug) (fixed)

Manipulate widgets in Customizer - Blue lines in Firefox

Reported by: GrahamArmfield Owned by: ocean90
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.9
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

I'm on a Windows 7 machine (64 bit) and I'm experiencing this on FF 30 - but not Chrome 35.

When tabbing through the widgets in a sidebar in the Customizer, some extra blue lines appear to the left of the selected widget.

Steps to recreate:

  • Tab to Appearance > Customize and press Enter
  • Tab to Widgets section and press Enter
  • Tab to one of the sidebars (that contains widgets) and press Enter
  • Tab to the widgets and the blue lines appear

I have attached a screenshot.

Attachments (2)

customizer-blue-lines.jpg (36.0 KB) - added by GrahamArmfield 3 years ago.
Extra blue lines indicated with red arrow
28834.patch (670 bytes) - added by nvwd 3 years ago.
removes the outline from widget action links

Download all attachments as: .zip

Change History (7)

@GrahamArmfield
3 years ago

Extra blue lines indicated with red arrow

#1 @westonruter
3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.0
  • Version changed from trunk to 3.9

Yeah, the element receiving focus should probably have outline:0 to override the default border style applied by Firefox on that OS.

#2 follow-up: @GrahamArmfield
3 years ago

But there does need to be some obvious focus indication.

#3 in reply to: ↑ 2 @westonruter
3 years ago

Replying to GrahamArmfield:

But there does need to be some obvious focus indication.

Yes. You can see the focus indication is the black arrow, whereas the unfocused indication is a gray arrow. It's perhaps too subtle, but that's the way it is supposed to be right now.

@nvwd
3 years ago

removes the outline from widget action links

#4 @nvwd
3 years ago

  • Keywords has-patch added; needs-patch removed

#5 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 29122:

Don't use box shadow focus styling for widget arrows, see #28267.

fixes #28834.
props nvwd.

Note: See TracTickets for help on using tickets.