Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#28840 closed defect (bug) (fixed)

Unnecessary Transitions when adding Media from Post or Page through "Add Media" button

Reported by: mikeyarce's profile mikeyarce Owned by: ocean90's profile ocean90
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords:
Focuses: Cc:


When adding Media through the Post or Page "Add Media" button, the media element has a transition that makes them slide in from the right. Here's an example screencast of the issue:

The Media is pulling in this line of code:

.attachments-browser .attachments, .attachments-browser .uploader-inline {
   transition: all 1s ease-in-out 0s; 

Which is used for the "Add New" button on the Media page, to make the "Drop files anywhere to upload" transition down from the top.

I'm attaching a patch that just adds more specificity to the CSS so that the transition is only present on those elements on that page instead of on the "Add Media" modal on other pages. Not 100% I used the right top level class for the page, but in my test this seems to work.

Attachments (1)

28840.diff (414 bytes) - added by mikeyarce 10 years ago.
Add specificity to transition for "Add New" on Media page

Download all attachments as: .zip

Change History (4)

10 years ago

Add specificity to transition for "Add New" on Media page

#1 @helen
10 years ago

  • Milestone changed from Awaiting Review to 4.0

ocean90 noticed something along these lines earlier as well. I think some stuff is colliding between the library grid and the media modal, and possibly also with the JS that resizes the images.

That transition also needs to be way faster, like .25s maybe.

#3 @ocean90
10 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 29131:

Media Grid: Remove CSS transition from inline uploader.

props ericlewis.
fixes #28840.
see #28851.

Note: See TracTickets for help on using tickets.