Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#28850 closed defect (bug) (fixed)

Media Grid: Reduce fixed elements

Reported by: ocean90's profile ocean90 Owned by:
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords:
Focuses: ui, administration Cc:

Description (last modified by ocean90)

Currently the grid is placed in to the content via

.media-grid-view {
        position: fixed;
        bottom: 0;
        left: 160px;
        right: 0;
        top: 32px;
}

This makes the toolbar and the footer fixed and gives me lot of headache. The footer shouln't be fixed because it has no information related to the media grid, it's distracting. I'm not sure if the toolbar needs to be fixed too. Currently it has no real functionallity which needs to be always visible. (Maybe it's just the search.)

I wish it would be more like the themes browser. Just themes, nothing more. In the media grid I except just my beautiful media, nothing more.

Related issues:

  • Search size should match the search from theme browser
  • Toolbar shouldn't be full width, more like the one from the theme browser, otherwise you will get this: https://cloudup.com/cLRPsu_iRq0
  • Grid doesn't react to a folded admin menu
  • Unnecessary Transitions, see #28840
  • On smaller screens you have a huge gap between toolbar and attachments, see #28832

Attachments (5)

28850.patch (6.4 KB) - added by ocean90 9 years ago.
Includes #28825
28850.1.patch (7.2 KB) - added by ocean90 9 years ago.
28850.2.patch (8.8 KB) - added by ocean90 9 years ago.
28850.3.patch (10.2 KB) - added by ocean90 9 years ago.
28850.4.patch (1.0 KB) - added by michalzuber 9 years ago.
Changed search max-width

Download all attachments as: .zip

Change History (18)

#1 @ocean90
9 years ago

We could pin the toolbar on top if it's out of view, see revisions screen.

#2 @ocean90
9 years ago

  • Description modified (diff)

#3 @melchoyce
9 years ago

This makes the toolbar and the footer fixed and gives me lot of headache. The footer shouln't be fixed because it has no information related to the media grid, it's distracting. I'm not sure if the toolbar needs to be fixed too.

I agree. I wish the whole page scrolled.

This ticket was mentioned in IRC in #wordpress-dev by ericandrewlewis. View the logs.


9 years ago

@ocean90
9 years ago

Includes #28825

@ocean90
9 years ago

@ocean90
9 years ago

@ocean90
9 years ago

#5 @ocean90
9 years ago

  • Keywords has-patch added; needs-patch removed
  • Version set to trunk

28850.3.patch:

  • Sets position:static to most elements
  • Adjusts toolbar to match themes toolbar, includes fix for #28833
  • Fixes "Add New" button, fix for #28825
  • Makes strings translatable
  • Improves styling of no media message
  • Adds "Edit Metadata" tab to all items, "Edit Image" is still only for images
  • Includes first pass for help tab

#6 @ericlewis
9 years ago

Great work @ocean90!

Some reactions:

  • "No media found. Try a different search" will show up even if a user has not uploaded media, so we should consider serving different strings in context here.
  • This puts infinite scroll on drugs, automatically loading more attachments.

I'd say let's commit this and roll forward.

#7 @ocean90
9 years ago

In 29136:

Media Grid improvements:

  • Remove fixed elements.
  • Adjusts toolbar and search, fixes #28833.
  • Add link to Add New button, fixes #28825.
  • Add "Edit Metadata" tab to all items, "Edit Image" only for images
  • Make strings translatable.
  • First pass for help tab.

see #28850.

#8 @ocean90
9 years ago

  • Keywords needs-patch added; has-patch removed

ToDo

  • Review CSS for the inline uploader: There seems to be some lines which are unnecessary now.
  • I broke the blue overlay when dropping a file on that screen.
Last edited 9 years ago by ocean90 (previous) (diff)

#9 @michalzuber
9 years ago

Search should be in second row if screen max-width: 760px;, doesn't feel good at 1120px http://i.imgur.com/7xYhh4d.png

Last edited 9 years ago by michalzuber (previous) (diff)

@michalzuber
9 years ago

Changed search max-width

This ticket was mentioned in IRC in #wordpress-dev by michalzuber. View the logs.


9 years ago

#12 follow-up: @helen
9 years ago

ocean90 - anything left here? Can use #28851 for the uploader stuff instead.

#13 in reply to: ↑ 12 @ocean90
9 years ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

Replying to helen:
Looks good.

@michalzuber
It's the same as on the themes browser. With the upcoming date filter we need enough space, so no need for that patch.

Note: See TracTickets for help on using tickets.