Media Grid: Reduce fixed elements

[ocean90]

Currently the grid is placed in to the content via

.media-grid-view {
        position: fixed;
        bottom: 0;
        left: 160px;
        right: 0;
        top: 32px;
}

This makes the toolbar and the footer fixed and gives me lot of headache. The footer shouln't be fixed because it has no information related to the media grid, it's distracting. I'm not sure if the toolbar needs to be fixed too. Currently it has no real functionallity which needs to be always visible. (Maybe it's just the search.)

I wish it would be more like the themes browser. Just themes, nothing more. In the media grid I except just my beautiful media, nothing more.

Related issues:

• Search size should match the search from theme browser
• Toolbar shouldn't be full width, more like the one from the theme browser, otherwise you will get this: ​https://cloudup.com/cLRPsu_iRq0
• Grid doesn't react to a folded admin menu
• Unnecessary Transitions, see #28840
• On smaller screens you have a huge gap between toolbar and attachments, see #28832

[ocean90]

We could pin the toolbar on top if it's out of view, see revisions screen.

[melchoyce]

This makes the toolbar and the footer fixed and gives me lot of headache. The footer shouln't be fixed because it has no information related to the media grid, it's distracting. I'm not sure if the toolbar needs to be fixed too.

I agree. I wish the whole page scrolled.

[ocean90]

Includes #28825

[ocean90]

28850.3.patch​:

• Sets position:static to most elements
• Adjusts toolbar to match themes toolbar, includes fix for #28833
• Fixes "Add New" button, fix for #28825
• Makes strings translatable
• Improves styling of no media message
• Adds "Edit Metadata" tab to all items, "Edit Image" is still only for images
• Includes first pass for help tab

[ericlewis]

Great work @ocean90!

Some reactions:

• "No media found. Try a different search" will show up even if a user has not uploaded media, so we should consider serving different strings in context here.
• This puts infinite scroll on drugs, automatically loading more attachments.

I'd say let's commit this and roll forward.

[ocean90]

In 29136:

Media Grid improvements:

• Remove fixed elements.
• Adjusts toolbar and search, fixes #28833.
• Add link to Add New button, fixes #28825.
• Add "Edit Metadata" tab to all items, "Edit Image" only for images
• Make strings translatable.
• First pass for help tab.

see #28850.

[ocean90]

ToDo

• Review CSS for the inline uploader: There seems to be some lines which are unnecessary now.
• I broke the blue overlay when dropping a file on that screen.

[michalzuber]

Search should be in second row if screen max-width: 760px;, doesn't feel good at 1120px and above ​http://i.imgur.com/7xYhh4d.png

[michalzuber]

Changed search max-width

[michalzuber]

Related #28677

[helen]

ocean90 - anything left here? Can use #28851 for the uploader stuff instead.

[ocean90]

Replying to helen:
Looks good.

@michalzuber
It's the same as on the themes browser. With the upcoming date filter we need enough space, so no need for that patch.