WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#28851 closed defect (bug) (fixed)

Media Grid: Improve uploader

Reported by: ocean90 Owned by:
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Media Keywords:
Focuses: ui, administration Cc:

Description (last modified by ocean90)

After clicking Add New the uploader flies in. The status of the button is unchanged, clicking it again will hide the uploader again. I think the button should hold the active state while the uploader is visible.

Correct me if I'm wrong but currently there is no other place where we let elements fly around. And we shouldn't start to this. I want the uploader immediately and don't want to wait for a second until the animation has finished. I prefer more something like we have on media-new.php or theme-install.php?upload, which is less distracting for uploading files.

We probably should also mention, that the whole screen is a dropzone for the uploader.

Related Issues:

  • When you scroll to the end of the grid and click Add New you will get the uploader which overlays the the first half of the media. So it's possible that you won't see that you media has been uploaded because the new media is placed on top of the list, which I currently can't see. Feels wrong.
  • Uploaded files will be selected, also when uploading multiple files, but multiple selection should be disabled until bulk edit is activated.

Attachments (6)

28851.diff (802 bytes) - added by ericlewis 6 years ago.
28851.2.diff (2.4 KB) - added by ericlewis 6 years ago.
28851.3.diff (2.4 KB) - added by ericlewis 6 years ago.
Screenshot 2014-07-15 13.28.11.png (495.7 KB) - added by ericlewis 6 years ago.
28851.4.diff (1.9 KB) - added by michalzuber 6 years ago.
Edit of 28851.3.diff, props ocean90
28851.5.diff (362 bytes) - added by michalzuber 6 years ago.
Remove h3 margin: 0

Download all attachments as: .zip

Change History (25)

#1 @ocean90
6 years ago

  • Description modified (diff)

@ericlewis
6 years ago

#2 @ericlewis
6 years ago

attachment:28851.diff removes CSS transitions in lieu of some classic display: none. Also fixes #28840

#3 @ocean90
6 years ago

In 29131:

Media Grid: Remove CSS transition from inline uploader.

props ericlewis.
fixes #28840.
see #28851.

@ericlewis
6 years ago

@ericlewis
6 years ago

#4 @ericlewis
6 years ago

In 28851.3.diff:

  • Parity of language and general styling on media-new.php.
  • Adding the dashed line lets a user know that they can drag and drop media without reading any text.
  • De-emphasize the select files button.
  • Tighten up the close button placement.
  • Remove a period at the end of "Maximum upload file size: 32 MB.", as that isn't really a sentence.

This ticket was mentioned in IRC in #wordpress-dev by ericandrewlewis. View the logs.


6 years ago

#6 @ericlewis
6 years ago

  • Keywords has-patch added; needs-patch removed

#7 @michalzuber
6 years ago

Much better, separates No media found. Try a different search. message from uploader http://i.imgur.com/9xftDyt.png

#8 follow-up: @ocean90
6 years ago

  • Keywords needs-refresh added
  • <p>or</p> has no i18n
  • Don't remove the fullstop in "Maximum upload file size: %s.", othwise we have two strings for the same (see /wp-admin/includes/media.php)

@michalzuber
6 years ago

Edit of 28851.3.diff, props ocean90

#9 in reply to: ↑ 8 @michalzuber
6 years ago

  • Keywords needs-refresh removed

Replying to ocean90:

  • Don't remove the fullstop in "Maximum upload file size: %s.", othwise we have two strings for the same (see /wp-admin/includes/media.php)

Right, good idea wp-admin/includes/media.php#L1859

#10 @wonderboymusic
6 years ago

In 29296:

Media Grid: improve uploader styles.

Props michalzuber, ericlewis.
See #28851.

#11 @michalzuber
6 years ago

props ocean90, too ;)

#12 @ocean90
6 years ago

In 29303:

Media Grid: Add context for "or" in [29296].

see #28851.

#13 @ocean90
6 years ago

In 29304:

Media Grid: Improve dropzone margins when viewport height is <400px.

see #28851.

#14 follow-up: @ocean90
6 years ago

  • Keywords needs-patch added; has-patch removed

There is no visible error message when file size is above the maximum file size.

#15 in reply to: ↑ 14 @ocean90
6 years ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

Replying to ocean90:

There is no visible error message when file size is above the maximum file size.

See #29037.

#16 follow-ups: @michalzuber
6 years ago

Remove margin: 0; at wp-includes/css/media-views.css#L1273, because h3 is too near to the border http://i.imgur.com/wzbMy6S.png

@michalzuber
6 years ago

Remove h3 margin: 0

#17 @azaozz
6 years ago

In 29373:

Media modal: use the same classes to hide the "or" that is above the "Select files" button when no drag-drop support. See #28851.

#18 in reply to: ↑ 16 @michalzuber
6 years ago

Replying to michalzuber:

Remove margin: 0; at wp-includes/css/media-views.css#L1273, because h3 is too near to the border http://i.imgur.com/wzbMy6S.png

Could somebody check that h3 fix 28851.5.diff ?

#19 in reply to: ↑ 16 @ocean90
6 years ago

Replying to michalzuber:

See ticket:28963:5.

Note: See TracTickets for help on using tickets.