Remove title attribute for plugin action links; add screen-reader-text

[joedolson]

Information in title attributes may not be available to screen readers; patch moves plug-in name from title attribute into screen reader text directly in link.

Leaves title attribute on Installed notice; not clear how important the notification that the plug-in is up to date is. To me, it seems unimportant, so I'm OK with leaving it uncertain whether a screen reader will be able to get that information. Removing it from the title attribute would make it unavailable to sighted users, if it's hidden as screen reader text.

[joedolson]

Removes title attributes from plugin action links.

[ocean90]

There should be no HTML in strings for translation.

Related: #26167, can we use aria-label here too?

[joedolson]

We could use aria-label; but actually aria-labelledby would probably be better. That would just require adding an ID to the title, and we could avoid the duplication of text. Patch coming.

[joedolson]

Instead of screen reader hidden, aria-labelled by

[joedolson]

This patch also updates plugin-install.js to add a data-title attribute and pull Thickbox title from the data-title rather than from the now-absent title attribute. Also corrects plugin-install.js so that it references a valid selector (.plugin-card rather than .plugin), so that the title info will actually be inserted.

[wonderboymusic]

In 29201:

In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.

Props joedolson.
Fixes #28853.

[ocean90]

In [29201] the id="<?php echo $plugin['slug']; ?>" part from 28853.2.patch​ is missing, see #29018.

[ocean90]

#29018 was marked as a duplicate.

[nvwd]

using aria-label instead of aria-labelledby

[nvwd]

My understanding about aria-labelledby is that it expects a value of an element IDs that are the labels for the object. Reference: ​https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute

aria-label seems to be appropriate here.

[DrewAPicture]

+ translator comments

[DrewAPicture]

id for labelled-by

[DrewAPicture]

Looks like there's two options on the table:

1. 28853.4.patch​ adds translator comments to the changes from 28853.3.patch​, which switches to using aria-label

2. 28853.5.patch​, which adds the id attribute missed in [29201]

[nvwd]

I would use the aria-lable instead of aria-labelledby since a meaningful value can't easily be created. The ID provided for aria-labelledby would be able to get the title of the plugin without the word Install or Update for assistive technologies.

[joedolson]

aria-label allows you to more easily customize the translations, definitely, because it doesn't require using a pair of IDs sequentially to string texts together.

aria-labelledby would require an ID pointing at the action text (e.g. "Update") and a separate ID pointing to the title of the plug-in, but wouldn't allow easy flexibility in word order for different languages.

I'd recommend going the aria-label route.

[DrewAPicture]

28853.4.patch​ seems to be ready to go then.

[wonderboymusic]

In 29424:

After [29201], use aria-label instead of aria-labelledby in WP_Plugin_Install_List_Table::display_rows().

Props nvwd, DrewAPicture.
Fixes #28853.