Remove unused $check_urls and $description variables from wp-admin/includes/dashboard.php

[michalzuber]

Variable $check_urls is passed by function param and the redefined version of it on line 833 isn't used.
URLs passed to the callback are from the function param $args = array_slice( func_get_args(), 2 );

The $description variable on line 1096 is not used afterwards.

[ocean90]

In 29130:

Remove unused variable in wp_dashboard_plugins_output(). Unused since [26144].

props michalzuber.
see #28872.

[ocean90]

Variable $check_urls

So func_get_args() ignores empty arguments and returns a copy of the passed arguments, means you can't override it. Has it ever worked?

[wonderboymusic]

$func = function ( $one, $two, $three = array() ) {
    $three = 3;
    print_r( func_get_args() );
};

$func( 1, 2 );

Results in:

Array
(
    [0] => 1
    [1] => 2
)

This never worked - that dashboard code is beyond bizarre

[michalzuber]

Replaced func_get_args()

[michalzuber]

@ocean90 what's wrong with 28872.2.diff ?
Isn't it a bit cleaner without array slicing and shifting? If I'm missing something, I apologize.

[ocean90]

@michalzuber It's possible to pass more arguments to wp_dashboard_cached_rss_widget(), these would be missing with 28872.2.diff.

I have no idea how wp_dashboard_cached_rss_widget() is used by others, but I prefer 28872.2.diff too.

[wonderboymusic]

In 29442:

wp_dashboard_cached_rss_widget() contained some func_get_args() code that was indescribably weird.
This keeps it weird, but makes sure that $check_urls gets passed to the callback.

Props michalzuber, ocean90.
Fixes #28872.