Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#28875 closed defect (bug) (invalid)

Replace include with global $wp_version

Reported by: michalzuber's profile michalzuber Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Possible candidates.

src/wp-admin/includes/class-wp-upgrader.php:1396:               include( ABSPATH . WPINC . '/version.php' ); // $wp_version;
src/wp-admin/includes/class-wp-upgrader.php:1540:               include( ABSPATH . WPINC . '/version.php' ); // $wp_version; // x.y.z
src/wp-admin/includes/import.php:122:   include( ABSPATH . WPINC . '/version.php' ); // include an unmodified $wp_version
src/wp-admin/includes/update.php:401:   include( ABSPATH . WPINC . '/version.php' ); // include an unmodified $wp_version
src/wp-admin/load-scripts.php:128:require(ABSPATH . WPINC . '/version.php');
src/wp-admin/load-styles.php:96:require( ABSPATH . WPINC . '/version.php' );
src/wp-includes/load.php:766:   require ABSPATH . WPINC . '/version.php';
src/wp-includes/script-loader.php:51:   include( ABSPATH . WPINC . '/version.php' ); // include an unmodified $wp_version
src/wp-includes/script-loader.php:566:  include( ABSPATH . WPINC . '/version.php' ); // include an unmodified $wp_version
src/wp-includes/update.php:28:  include( ABSPATH . WPINC . '/version.php' ); // include an unmodified $wp_version
src/wp-includes/update.php:186: include( ABSPATH . WPINC . '/version.php' ); // include an unmodified $wp_version
src/wp-includes/update.php:332: include( ABSPATH . WPINC . '/version.php' ); // include an unmodified $wp_version
src/wp-includes/update.php:567: include( ABSPATH . WPINC . '/version.php' ); // include an unmodified $wp_version
src/wp-load.php:61:     require_once( ABSPATH . WPINC . '/version.php' );
src/wp-settings.php:30:require( ABSPATH . WPINC . '/version.php' );

Attachments (1)

28875.patch (2.9 KB) - added by michalzuber 11 years ago.
Some replacements that I tested.

Download all attachments as: .zip

Change History (4)

@michalzuber
11 years ago

Some replacements that I tested.

#1 @michalzuber
11 years ago

Sure some regression might appear :P, made ticket for discussion.

#2 @ocean90
11 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

The global can be changed, therefore the comment // include an unmodified $wp_version.

#3 @SergeyBiryukov
11 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.