Changes between Version 1 and Version 2 of Ticket #28883, comment 19
- Timestamp:
- 08/20/2014 03:02:05 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #28883, comment 19
v1 v2 3 3 I've looked at the gist of it, and was able to get to what I think is a decent handling in attachment:28883.7.diff. But as you can see in the last screenshot of https://cloudup.com/cN4DcBMqDi5, I've noticed that our banner handling is sketchy at smaller width (but tall) because we decide to switch to the other mode based on the screen height. 4 4 5 attachment:28883.7-widthonly.diff is the same as 28883.7.diff, but by detecting small-screen mode based on screen width height<771px, like the rest, not height<500px. Any narrow screen can benefit from the smaller banner. This could also be its own ticket, but I figured I'd give you the option to do either.5 attachment:28883.7-widthonly.diff is the same as 28883.7.diff, but by detecting small-screen mode based on screen width<771px, like the rest, not height<500px. Any narrow screen can benefit from the smaller banner. This could also be its own ticket, but I figured I'd give you the option to do either. 6 6 7 7 See https://cloudup.com/czeF7wzz-07