WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #28888, comment 8


Ignore:
Timestamp:
05/29/17 19:24:58 (4 months ago)
Author:
afercia
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28888, comment 8

    initial v1  
    1616- should have some screen reader text to say what it does: "Edit {widget name} widget" and when expanded "Close {widget name} widget" 
    1717- the "Remove" and "Close" links should be buttons 
    18 - looks like the "save as you type" saves on each keystroke. Should really try to detect when users actually end typing. See for example what was done for the Themes search using `_.debounce` in #26600 and #31812 
     18- looks like the "search as you type" searches on each keystroke. Should really try to detect when users actually end typing. See for example what was done for the Themes search using `_.debounce` in #26600 and #31812 
    1919- the "Remove" label: it says "Remove" and has a title attribute `"Trash widget by moving it to the inactive widgets sidebar."` So is it removing, trashing, or moving? What is the "widgets sidebar" in the Customizer context? Bit confusing and doesn't explain the most important thing: settings/content will be preserved. 
    2020