WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#28894 closed defect (bug) (fixed)

WP_MS_Sites_List_Table::display_rows() must be public

Reported by: extendwings Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Networks and Sites Keywords: has-patch
Focuses: administration, multisite Cc:

Description

At 4.0-beta1-20140713, I got following error from PHP when I visit wp-admin/network/sites.php.

[14-Jul-2014 14:54:26 UTC] PHP Fatal error:  Access level to WP_MS_Sites_List_Table::display_rows() must be public (as in class WP_List_Table) in /path/to/wordpress/wp-admin/includes/class-wp-ms-sites-list-table.php on line 0

r28493 made WP_List_Table::display() protected. And r29137 made it public without changing WP_MS_Sites_List_Table::display_rows().

Attachments (1)

28894.patch (455 bytes) - added by extendwings 6 years ago.

Download all attachments as: .zip

Change History (5)

@extendwings
6 years ago

#1 @extendwings
6 years ago

  • Focuses administration added
  • Keywords has-patch added

#2 @wonderboymusic
6 years ago

Argh - you are correct. Thanks for the ticket!

#3 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 29166:

Missed one: WP_MS_Sites_List_Table::display_rows() must be public.

Props extendwings.
Fixes #28894.

#4 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.0
Note: See TracTickets for help on using tickets.