Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#28898 closed defect (bug) (fixed)

Theme-install preview toolbars don't consistently load

Reported by: melchoyce's profile melchoyce Owned by: markjaquith's profile markjaquith
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: Themes Keywords: has-patch
Focuses: administration Cc:


The "add theme" preview toolbar doesn't consistently load for me. See it in action:

Not seeing anything in the console.

Attachments (1)

28898.patch (326 bytes) - added by ocean90 10 years ago.

Download all attachments as: .zip

Change History (11)

#1 @celloexpressions
10 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 4.0
  • Summary changed from Theme preview toolbars don't consistently load to Theme-install preview toolbars don't consistently load

Most likely a browser rendering issue, but something we may be able to fix. I can't reproduce in Chome 36 or Firefox 31 on Windows 8.1, even with navigating in and out of the previewer very quickly with the keyboard.

There's a good chance this was introduced in 4.0 with the changes from buttons to icons here; @melchoyce, can you try it on other browsers and in 3.9 and narrow down where the issue is? If it isn't a regression, we need to punt it.

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.

10 years ago

#3 @adamsilverstein
10 years ago

Mel, I tried to reproduce the issue mentioned in this ticket without luck - although your screen-cast makes it look easy.

I tried in Chrome/Dev and Firefox. Any tricks to getting the bug to surface? what browser are you using?

#4 @helen
10 years ago

  • Milestone changed from 4.0 to Awaiting Review

Punting for now, this may very well be a "worksforme" situation even though I know it's been happening to melchoyce for a while now.

#5 @ocean90
10 years ago

Seeing this now too in Chrome 37/OSX, see

10 years ago

#6 @ocean90
10 years ago

With 28898.patch I see the header and footer again. But no idea what's going on here.

#7 @ocean90
10 years ago

Seems like an issue in combination with a Retina screen. On a Retina screen it's hidden, after moving the browser to the my second screen (non-Retina) header and footer are coming back.

#8 @adamsilverstein
10 years ago

  • Keywords has-patch added

verified the patch fixes the problem. i think removing overflow: auto; makes sense, not sure why its there. I didn't see any adverse side effects from the change and after the patch can no longer reproduce the issue.

looks good, nice catch!

#9 @johnbillion
10 years ago

  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 4.1

#10 @markjaquith
10 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 30101:

Fix weird HiDPI screen rendering issue with theme install preview toolbar

fixes #28898
props ocean90

Note: See TracTickets for help on using tickets.