WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #28905, comment 36


Ignore:
Timestamp:
08/19/2014 11:42:18 PM (11 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #28905, comment 36

    initial v1  
    11I'm still at a loss here.
    22- All audio/video/playlist views seem to use `wp_ajax_parse_media_shortcode()`. Is the block about audio and video in `wp_ajax_parse_embed()` still needed (https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/ajax-actions.php#L2678).
    3 - If yes, `wp_ajax_parse_embed()` and `wp_ajax_parse_media_shortcode()` seem to repeat quite a bit of code. Merge them?
     3- If yes, `wp_ajax_parse_embed()` and `wp_ajax_parse_media_shortcode()` seem to repeat quite a bit of code. Merge them? Or perhaps parse_media_shortcode() should be a helper function called from wp_ajax_parse_embed()?
    44