#28934 closed defect (bug) (duplicate)
Remove unneeded div.separator from admin menu
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch |
Focuses: | administration | Cc: |
Description
I was researching the
/* @todo: is this even needed given that it's nested beneath the above li.wp-menu-separator? */
wordpress-svn$ grep -r 'div.*class=".*separator' src |head src/wp-admin/menu-header.php:110: echo '<div class="separator"></div>';
Is it necessary to have
#adminmenu div.separator { height: 2px; padding: 0; }
The parent <li> has bigger height than that <div>, it is lost there
#adminmenu li.wp-menu-separator { height: 5px; padding: 0; margin: 0 0 6px 0; cursor: inherit; }
Attachments (1)
Change History (8)
#4
follow-up:
↓ 5
@
11 years ago
- Milestone Awaiting Review deleted
- Resolution set to duplicate
- Status changed from new to closed
Duplicate of #26960.
#6
in reply to:
↑ 5
@
11 years ago
Replying to michalzuber:
I'm going over the
@TODO
s in the code.
I put the CSS todos in there myself in 3.9. I would like to not focus on that right now - working on an overall roadmap to be published after 4.0, or possibly shortly before release. I appreciate you looking at them, and it is good to know who may be interested in moving forward in general. As for the admin menu in general, it needs a good look at the totality of the markup and CSS. My ticket description and azaozz's comment should give you a good idea of where our thoughts are there.
Related #24104 ?