WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#28945 closed defect (bug) (fixed)

Media Grid: Edit icon 'link' does not behave as expected

Reported by: Ipstenu Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords:
Focuses: ui Cc:

Description

From https://wordpress.org/support/topic/media-grid-issues

In hovering over the pencil icon it does two bad things:
1) flutters uncontrollably and
2) when you manage to click it, it doesn't go to the edit screen.

You can see both these behaviors in this screencast.

http://screencast.com/t/OcAkRkmOdRK3

I can reproduce this issue. The expected behavior would be no flicker (mine stops FWIW on Chrome) and immediate edit, instead of select. This is possibly related to changes made for the select box?

Change History (9)

#1 @mrwweb
6 years ago

This is possibly related to changes made for the select box?

I believe I observed the issue before the checkboxes were added.

#2 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.0

#3 @mordauk
6 years ago

I've just reproduced this as well.

#4 @SergeyBiryukov
6 years ago

2) when you manage to click it, it doesn't go to the edit screen.

See #28952.

#5 @ericlewis
6 years ago

This is fixed in my patch on #28965

#6 @SergeyBiryukov
6 years ago

#28974 was marked as a duplicate.

#7 @helen
6 years ago

I think we should just get rid of the icon. It's non-destructive to click on an item, and a user's action might just be to look at a preview, not necessarily edit.

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


6 years ago

#9 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 29288:

Media Grid: remove pencil icon from attachment hover and a bunch of unused CSS.

Fixes #28945.

Note: See TracTickets for help on using tickets.