WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#28952 closed defect (bug) (invalid)

Media Grid: "Uploaded To" link is not clickable

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords: has-patch dev-feedback
Focuses: ui, javascript, administration Cc:

Description

In "Uploaded To" line in the media grid, post title is a link (see the screenshot).

When you click on it, the item gets selected, like when clicking on the rest of the text.

Attachments (2)

28952.png (61.7 KB) - added by SergeyBiryukov 6 years ago.
28952.patch (851 bytes) - added by michalzuber 6 years ago.

Download all attachments as: .zip

Change History (9)

@SergeyBiryukov
6 years ago

@michalzuber
6 years ago

#1 @michalzuber
6 years ago

  • Keywords has-patch dev-feedback added

Sorry, but don't know how to better implement that click in Backbone :P

#2 follow-up: @gauravmittal1995
6 years ago

  • Summary changed from Media Grid: "Uploaded To" link is not clickable to Media Grid: "Uploaded To" link and "Edit Media" icon are not clickable

Also the "Edit Media" icon (the pencil icon on the top left while hovering) is not clickable.

#3 @SergeyBiryukov
6 years ago

#28974 was marked as a duplicate.

#4 follow-up: @ericlewis
6 years ago

This is because media.view.Attachment binds all anchor clicks to preventDefault here.

All anchors should be reviewed in this template (and any child classes that don't override the events hash). We should change any of these anchors to buttons that are not hyperlinks to avoid requiring preventDefault triggered on click.

#5 in reply to: ↑ 2 @helen
6 years ago

  • Summary changed from Media Grid: "Uploaded To" link and "Edit Media" icon are not clickable to Media Grid: "Uploaded To" link is not clickable

Replying to gauravmittal1995:

Also the "Edit Media" icon (the pencil icon on the top left while hovering) is not clickable.

Please don't double up on a ticket like that. There was a ticket open for that already: #28945.

#6 in reply to: ↑ 4 @michalzuber
6 years ago

Replying to ericlewis:

All anchors should be reviewed in this template (and any child classes that don't override the events hash). We should change any of these anchors to buttons that are not hyperlinks to avoid requiring preventDefault triggered on click.

Great point by ericlewis, it's a bit weird to prevent all events than rewrite their actions.

#7 @wonderboymusic
6 years ago

  • Milestone 4.0 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Not pertinent since [29280].

Note: See TracTickets for help on using tickets.