WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#28963 closed defect (bug) (fixed)

Media type filter and search error message in modal has changed

Reported by: paulwilde Owned by: ocean90
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords: needs-patch
Focuses: ui Cc:

Description

The error message when you filter by media type and get no results has changed from 3.9. This is the same when searching too.

Previously a properly aligned message would display with the ability to upload files. Now it just shows some generic text that is no longer aligned.

Attachments (5)

no-items-3.9.png (70.3 KB) - added by paulwilde 6 years ago.
no-items-4.0.png (53.4 KB) - added by paulwilde 6 years ago.
28963.patch (3.1 KB) - added by ocean90 6 years ago.
28963.png (61.5 KB) - added by ocean90 6 years ago.
28963.2.patch (2.6 KB) - added by ocean90 6 years ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.0

#2 @ericlewis
6 years ago

  • Keywords needs-patch added

@ocean90
6 years ago

#3 @ocean90
6 years ago

In 29364:

Media Modal: Restore uploader view, when no items are found.

see #28963.

@ocean90
6 years ago

#4 @ocean90
6 years ago

Needs a decision about the strings and the button size. Have in mind, that the view is currently shared with the media grid.

#5 @ocean90
6 years ago

In [29364] data.message = this.options.message; was added, means "No items found." exists now always and .has-upload-message is set, which produces different margins, see ticket:28851:16. Have to check how this was set in 3.9.

#6 @ocean90
6 years ago

#29239 was marked as a duplicate.

@ocean90
6 years ago

#7 @ocean90
6 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 29532:

Media Modal: Restore to the previous filter and search error message.

fixes #28963.

Note: See TracTickets for help on using tickets.