WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28964 closed defect (bug) (fixed)

Remove unused argument $page in install_plugins_upload()

Reported by: michalzuber's profile michalzuber Owned by: dd32's profile dd32
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.9
Component: Plugins Keywords: has-patch
Focuses: administration Cc:

Description

I checked 2.8 version when the install_plugins_upload() was introduced https://core.trac.wordpress.org/browser/branches/2.8/wp-admin/includes/plugin-install.php#L210
The other functions like install_popular(), install_new(), install_featured() and install_updated() used that param.

Attachments (2)

28964.patch​ (565 bytes) - added by michalzuber 10 years ago.
28964.2.patch​ (602 bytes) - added by michalzuber 10 years ago.
Removed also the documentation line

Download all attachments as: .zip

Change History (6)

@michalzuber
10 years ago

@michalzuber
10 years ago

Removed also the documentation line

#1 @michalzuber
10 years ago

  • Keywords has-patch added

#2 @michalzuber
10 years ago

  • Keywords dev-feedback added

#3 @dd32
10 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 31326:

Remove an unused parameter on install_plugins_upload().
Props michalzuber. Fixes #28964

#4 @dd32
10 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 4.2
Note: See TracTickets for help on using tickets.