Media Grid JavaScript Clean-up

[ericlewis]

Media Grid has been developed in a flurry.

Let's sweep through and fix up where urgency previously trumped cleanliness.

[ericlewis]

In attachment:28965.diff​:

• Instead of using an explicitly stated CSS class at the top-level frame of media grid,

use the mode-grid selector to apply styles.

• Remove the edit mode, which is cruft from a different implementation of bulk edit.
• Remove screen options CSS, which is unnecessary since the grid is not styled fixed.
• Use more self-documenting function names, e.g. createViewForContentRegionInBrowseMode, which while verbose, is more useful than createBrowse
• For media.controller.EditAttachmentMetadata state, remove unnecessary function overloading in lieu of setting region defaults to false in the options hash.
• Move mode functionality from media.view.MediaFrame to media.view.Frame`.
• Remove the custom events hash from media.view.Attachment.Details.TwoColumn. Closer method parity with its parent media.view.Attachment.Details.
• Remove unnecessary methods: media.view.Attachment.Details.render
• Fix up the image editor view loading business in media.view.MediaFrame.EditAttachments

[ericlewis]

In attachment:28965.2.diff​:

• More documentation.
• Replace media.view.MediaFrame.EditAttachments.editMetadataContent with media.view.MediaFrame.EditAttachments.createViewForContentRegionInEditMetadataMode (self-documenting method naming), and clean up the implementation.

[wonderboymusic]

In 29266:

Media Grid: general JS cleanup.

Props ericlewis.
See #28965.

[wonderboymusic]

I left out the iOS-style method name changes for now - I think better docs would alleviate the need for those.

[afercia]

Replying to wonderboymusic:

In 29266:
Media Grid: general JS cleanup.

hi,
after this I get a blank media grid, no grid items at all, no js errors in the console. I have to add back "router: false" to the default states in media-grid.js but I'm totally new to backbone.js sorry I can't help more.

[wonderboymusic]

a lot was tackled here

[ericlewis]

In attachment:28965.3.diff​: per @koop, don't select body with jQuery.

[wonderboymusic]

In 29367:

Media Grid: don't select body with jQuery when instantiating media.view.UploaderWindow.

Props ericlewis.
See #28965.

[koop]

For clarity's sake: document.body is the body element itself, not a jQuery collection. In this case, it'll happen to work either way (which I dislike, I'd rather a more specific API).

Also, I think the container property might be vestigial at this point.

(Also, hey everyone.)

[wonderboymusic]

This ticket, like #24716, is too broad at this point. We should open tickets for specific things we are doing, or just reference other tickets that we are expanding upon when committing.