Checkbox icon is a bit out of place in RTL

[iseulde]

See screenshots.

[iseulde]

It probably also needs to be flipped.

[SergeyBiryukov]

We have forms-rtl.css and l10n-rtl.css, but login-rtl.css still includes non-RTL versions.

There's a Grunt task to replace imported CSS file names in wp-admin-rtl.css, but not in other RTL files.

28966.patch​ should take care of that.

[SergeyBiryukov]

In 29256:

Gruntfile: Change import rules to include RTL stylesheets when running CSSJanus.

see #28966.

[SergeyBiryukov]

28966.2.patch​ flips checkboxes in RTL: 28966.flipped.png​. Removing width: 16px is intentional and doesn't seem to affect LTR.

[ramiy]

Sergey, removing the width: 16px fixes the UI glitch. But the rotateY(180deg) is irrelevant.

[SergeyBiryukov]

Replying to ramiy:

Sergey, removing the width: 16px fixes the UI glitch. But the rotateY(180deg) is irrelevant.

Without rotateY(180deg), I don't see a UI glitch: 28966.current.png​. And removing width: 16px doesn't seem to make a difference in that case.

Should we just leave it as is then?

[ramiy]

Replying to SergeyBiryukov:

Replying to ramiy:

Sergey, removing the width: 16px fixes the UI glitch. But the rotateY(180deg) is irrelevant.

Without rotateY(180deg), I don't see a UI glitch: 28966.current.png​. And removing width: 16px doesn't seem to make a difference in that case.

Should we just leave it as is then?

Sergey, try width: initial; it works too. RotateY is still irrelevant.

[SergeyBiryukov]

I mean, 28966.current.png​ is what I see in current trunk after [29256]. Removing width: 16px or changing it to width: initial doesn't make any difference. If the checkbox does not need to be flipped, we can leave it as is.

The results of [29256] are not in the current nightly build yet, should be in the next one.

To see the changes sooner, try updating these two lines in wp-admin/css/login-rtl.css:

@import url(forms.css);
@import url(l10n.css);

to use forms-rtl.css and l10n-rtl.css.

[SergeyBiryukov]

Closing as fixed in [29256].