Opened 10 years ago
Closed 10 years ago
#28976 closed defect (bug) (fixed)
Add Media Panel: Announce context of close button for screen readers
Reported by: | joedolson | Owned by: | wonderboymusic |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Media | Keywords: | has-patch |
Focuses: | accessibility | Cc: |
Description
The current text of the Add Media Panel close button is just "Close". For screen readers, it's important to be notified what will be closed when you select this option, so that they can be certain that they're closing the right thing.
Changes text to "Close Media Panel" to provide context for screen readers.
Same patch also changes Close text from being a title attribute (which will only be announced in some screen readers with some configurations) screen-reader-hidden text.
Related: #25105
Attachments (2)
Change History (7)
#2
@
10 years ago
hi,
if just text, esc_attr_e should be removed in favor of just _e
I would suggest also to don't use capitalized first letters for "Close Media Panel". These things tend to be confusing for translators and often lead to have duplicated strings to translate, the capitalized version, the non-capitalized version...
Provide context for close; move to screen reader text