WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#28976 closed defect (bug) (fixed)

Add Media Panel: Announce context of close button for screen readers

Reported by: joedolson Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords: has-patch
Focuses: accessibility Cc:

Description

The current text of the Add Media Panel close button is just "Close". For screen readers, it's important to be notified what will be closed when you select this option, so that they can be certain that they're closing the right thing.

Changes text to "Close Media Panel" to provide context for screen readers.

Same patch also changes Close text from being a title attribute (which will only be announced in some screen readers with some configurations) screen-reader-hidden text.

Related: #25105

Attachments (2)

28976.patch (711 bytes) - added by joedolson 6 years ago.
Provide context for close; move to screen reader text
28976.2.patch (705 bytes) - added by joedolson 6 years ago.
Updates per suggestions from afercia

Download all attachments as: .zip

Change History (7)

@joedolson
6 years ago

Provide context for close; move to screen reader text

#1 @joedolson
6 years ago

  • Keywords has-patch added

#2 @afercia
6 years ago

hi,
if just text, esc_attr_e should be removed in favor of just _e
I would suggest also to don't use capitalized first letters for "Close Media Panel". These things tend to be confusing for translators and often lead to have duplicated strings to translate, the capitalized version, the non-capitalized version...

@joedolson
6 years ago

Updates per suggestions from afercia

#3 @michalzuber
6 years ago

How about "Close media modal dialog" ?

#4 @samuelsidler
6 years ago

  • Milestone changed from Awaiting Review to 4.0

#5 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 29295:

Media Grid: change text to "Close Media Panel" to provide context for screen readers.

Props joedolson.
Fixes #28976.

Note: See TracTickets for help on using tickets.