WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28980 closed defect (bug) (fixed)

Media Grid RTL Adjustments

Reported by: adamsilverstein's profile adamsilverstein Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch dev-feedback
Focuses: rtl Cc:

Description

Reviewing the new Media Grid for RTL issues most things auto-magically look good - the one thing I noticed is the arrows are revered in the media detail modal:

http://f.cl.ly/items/1E2V0k3p1H45131b423g/%D7%A1%D7%A4%D7%A8%D7%99%D7%99%D7%AA%20%D7%9E%D7%93%D7%99%D7%94%20%E2%80%BA%20sadasd%20%E2%80%94%20%D7%95%D7%95%D7%A8%D7%93%D7%A4%D7%A8%D7%A1%202014-07-21%2019-48-26%202014-07-21%2019-48-30.jpg

Attachments (2)

28980.diff​ (559 bytes) - added by adamsilverstein 10 years ago.
css overrides to swap arrow direction in rtl
28980.padding.png​ (24.6 KB) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (8)

@adamsilverstein
10 years ago

css overrides to swap arrow direction in rtl

#1 @adamsilverstein
10 years ago

  • Keywords has-patch dev-feedback added

28980.diff​

  • fixes arrow directions this with a css override, that seems simplest.

The actual direction you go when clicking seems correct, when you click on the arrow on the right you go back towards the beginning of the grid, which starts in the upper right; when you click the left side arrow you go forward.

the result is this:

http://cl.ly/image/3N2i10320B2i/%D7%A1%D7%A4%D7%A8%D7%99%D7%99%D7%AA%20%D7%9E%D7%93%D7%99%D7%94%20%E2%80%BA%20sadasd%20%E2%80%94%20%D7%95%D7%95%D7%A8%D7%93%D7%A4%D7%A8%D7%A1%202014-07-21%2019-57-22%202014-07-21%2019-57-27.jpg

#2 in reply to: ↑ description @adamsilverstein
10 years ago

  • are reversed, not revered :)

Replying to adamsilverstein:

Reviewing the new Media Grid for RTL issues most things auto-magically look good - the one thing I noticed is the arrows are revered in the media detail modal:

http://f.cl.ly/items/1E2V0k3p1H45131b423g/%D7%A1%D7%A4%D7%A8%D7%99%D7%99%D7%AA%20%D7%9E%D7%93%D7%99%D7%94%20%E2%80%BA%20sadasd%20%E2%80%94%20%D7%95%D7%95%D7%A8%D7%93%D7%A4%D7%A8%D7%A1%202014-07-21%2019-48-26%202014-07-21%2019-48-30.jpg

#3 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.0

#4 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29264:

Media Grid: Swap arrow direction in RTL in Attachment Details modal.

props adamsilverstein.
fixes #28980.

@SergeyBiryukov
10 years ago

#5 @SergeyBiryukov
10 years ago

If the Attachment Details modal has a scrollbar, there's a lack of padding (in Chrome 36): 28980.padding.png​.

Same issue as in #27629 and #28010, needs position: relative.

Last edited 10 years ago by SergeyBiryukov (previous) (diff)

#6 @SergeyBiryukov
10 years ago

In 29265:

Media Grid: Fix missing padding in RTL in Attachment Details modal.

see #28980.

Note: See TracTickets for help on using tickets.