Changes between Version 2 and Version 3 of Ticket #28983, comment 16
- Timestamp:
- 03/10/2021 09:38:45 PM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #28983, comment 16
v2 v3 1 1 @sabernhardt I guess I'm a bit lost when it comes to what "links" are being referred to in that bulleted list. 2 2 3 You can see in https://github.com/WordPress/wordpress-develop/pull/1082/files (and the most recent .diff file attached to the ticket ) that it's really just adding 2 code blocks to the `src/wp-includes/css/admin-bar.css` file that makes the admin bar take advantage of flexbox and ellipses-based text-overflow when applicable so the admin bar doesn't allow items to wrap onto a new line outside of the admin bar, if/when that happens due to any number of plugins potentially adding items to the admin bar (at that point, WordPress should be flexible in not having the admin bar break its layout at that point since it allows plugins to add items to the admin bar).3 You can see in https://github.com/WordPress/wordpress-develop/pull/1082/files (and the most recent .diff file attached to the ticket; though the GitHub PR has some additional dev notes) that it's really just adding 2 code blocks to the `src/wp-includes/css/admin-bar.css` file that makes the admin bar take advantage of flexbox and ellipses-based text-overflow when applicable so the admin bar doesn't allow items to wrap onto a new line outside of the admin bar, if/when that happens due to any number of plugins potentially adding items to the admin bar (at that point, WordPress should be flexible in not having the admin bar break its layout at that point since it allows plugins to add items to the admin bar). 4 4 5 5 This update then doesn't rely on or otherwise involve any plugin and shouldn't conflict with any plugins that I'm aware of that any update to the admin bar's styling might have (while addressing an active issue due to the inflexibility of the admin bar as it is now [while being perfectly seamless for those not affected by this issue] & being straightforward enough that plugins that are changing the admin bar's styling should be able to accommodate reasonably quickly & easily in an update.)