Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #28983, comment 37


Ignore:
Timestamp:
11/09/2022 03:28:47 PM (16 months ago)
Author:
KZeni
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28983, comment 37

    v2 v3  
    11@seedsca Interesting approach, but I'm not sure people would like to see some items being shown right in the menu while others are hidden behind a "More" menu (which often means they might as well not be there) simply due to the order in which they're showing in the menu & the current browser size. It might be helpful if plugins could opt into using the "More" menu (but we can't guarantee this will be used instead of adding directly to the menu bar so the issue may/will still persist with this change) or WordPress itself makes it so that plugins & things that try adding to the admin menu get added to the "More" menu at all times while the only things shown directly in the menu bar are the official WP menu items (but then that isn't the most flexible way to go about it even though it makes it much less likely [if not entirely] that there'll be a UI issue due to too many things trying to add items to the menu... some items a plugin/etc. might add really could make more sense to be shown directly in the menu bar rather than being presented in a sub-menu so it kinda introduces an issue while resolving another.)
    22
    3 As such, I do think the approach of truncating the text labels (even to the point of just showing their icon, if needed) is the best approach out of these (definitely mention if there's a different approach that I didn't consider that could work well). The icon should be sufficient in giving context for that menu item, it is similar to the mobile menu where they do just get reduced to being their icons, etc. while it then still tries to show as much of the text labels as possible so it's as helpful as it can be at a glance without ever having the items wrap to a new line. It's the one approach I've come across that resolves the issue without introducing another (while then also having it not totally rewrite how the menu bar is currently implemented/styled/etc.)
     3As such, I do think the approach of truncating the text labels (even to the point of just showing their icon, if needed) is the best approach out of these (definitely mention if there's a different approach that I didn't consider that could work well). The icon should be sufficient in giving context for that menu item, it is similar to the mobile menu where they do just get reduced to being their icons, etc. while it then still tries to show as much of the text labels as possible so it's as helpful as it can be at a glance without ever having the items wrap to a new line. It's the one approach I've come across that resolves the issue without introducing another (while then also having it not totally rewrite how the menu bar is currently implemented/styled/etc. & just needs some CSS adjustments per what's been previously provided here [or similar.])