Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #28983, comment 9


Ignore:
Timestamp:
03/08/2021 08:44:20 PM (3 years ago)
Author:
KZeni
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28983, comment 9

    v2 v3  
    11What's the best approach to decide the best code to move forward with for the final implementation?
    22
    3 Do we simply go with the newer patch (https://github.com/WordPress/wordpress-develop/pull/352)? I mean, it's fully addressing things with how it is now that then doesn't need any further modifications, really. At that point, it's been more thoroughly tested in comparison per it being available as a plugin for years now (which people have submitted updates to as items were found) as well as being more recent so it's less likely to have out-of-date styling/approaches coming into play? That'd also make the implementation a bit more straightforward.
     3Do we simply go with the newer patch (https://github.com/WordPress/wordpress-develop/pull/352)? I mean, it's fully addressing things with how it is now that then doesn't need any further modifications, really. At that point, it's been more thoroughly tested in comparison per it being available as a plugin for years now (which people have submitted updates to as items were found) as well as being more recent so it's less likely to have out-of-date styling/approaches coming into play. That'd also make the implementation a bit more straightforward.
    44
    55Also, should I close https://github.com/WordPress/wordpress-develop/pull/352/ in favor of re-creating a pull request under this ticket?
    66
    7 Open to thoughts for those more familiar/invovled with the WordPress core & patch approval process than myself here.
     7Open to thoughts for those more familiar/involved with the WordPress core & patch approval process than myself here.