#28984 closed defect (bug) (fixed)
Inputs (type=number) look too flattened
Reported by: | Caspie | Owned by: | michaelarestad |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | 3.8 |
Component: | Administration | Keywords: | has-patch needs-testing |
Focuses: | ui, administration | Cc: |
Description
Add line-height and height to number inputs to look similar to other inputs in the WP admin.
Patch is not too aggressive - covers inputs of the mentioned type, which also have small|large|regular-text class.
Attachments (7)
Change History (19)
#4
in reply to:
↑ 3
@
10 years ago
Replying to helen:
Browser?
Hey!
So far I saw it on latest Firefox, Chrome and IE. Even though each browser renders number field differently, it looks flattened in general. Haven't checked Safari.
Win 8.1
#5
@
10 years ago
- Keywords reporter-feedback removed
- Milestone changed from Awaiting Review to Future Release
- Version changed from trunk to 3.8
Though it's not as bad as in the screenshot, I can confirm that number inputs have a different total height (23px) than selects (28px) in Chrome, and there looks to be a similar issue in Firefox. Text inputs are 27px.
#6
@
10 years ago
Just checked and issue is valid and not only for number fields but any text input field. Tested Chrome, Firefox and Opera, screenshot above.
Added broader patch that solves this and also removes the "px" in a couple of "0px" occurrences.
This ticket was mentioned in Slack in #core by helen. View the logs.
9 years ago
#10
@
9 years ago
Looks like the changes are good. I moved them around a bit to keep with the current grouping patterns in forms.css, but left the values in tact.
Not really this issue, but mobile is pretty dang rough for form elements. I think we should attempt a redesign of the mobile form patterns because views like this are problematic: https://cloudup.com/cMYP-mZMvZY
screen